Migration tenders-finder#132
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
simantak-dabhade
left a comment
There was a problem hiding this comment.
🚨 Security: real API key committed — merge blocked
This PR commits a real TinyFish API key in tenders-finder/.env.local (introduced in commit 8627508). Since your fork is public, the key must be treated as compromised.
I've flagged this to @simantak-dabhade. Before any further review happens, please do the following, in order:
- Rotate the key immediately in the TinyFish dashboard and send Simantak a screenshot of the rotation as proof.
- Delete
tenders-finder/.env.localfrom the branch. - Add a
.gitignoreattenders-finder/.gitignore(and ideally fix the missing root-level one) covering at minimum:.env .env.local node_modules/ .next/ - Force-push the branch with the offending commit rewritten so the key is not in git history. Options:
git reset --soft <parent-of-8627508>→ re-stage without the secret → recommit →git push --force-with-lease- Or
git filter-repo --path tenders-finder/.env.local --invert-pathsthen force-push
Note for context: TruffleHog ran and passed because it doesn't ship a detector for the sk-mino- prefix yet. Absence of a TruffleHog finding is not the same as "no leaked secret." Always double-check with git ls-files | grep -E '\.env(\.|$)' before pushing.
Once the key is rotated, .env.local is gone from the branch history, and Simantak has your screenshot, I'll proceed with the full migration review.
|
Status update: @simantak-dabhade has confirmed the key was rotated. The exposed Still need to complete the cleanup before review can continue:
Heads-up: the same key was committed again in PR #147 two days later, so please adjust your local workflow to prevent a third occurrence — e.g., Once |
No description provided.