Skip to content

Migration stay-scout-hub#137

Closed
KrishnaAgarwal7531 wants to merge 2 commits intotinyfish-io:mainfrom
KrishnaAgarwal7531:mig-stay-scout-hub
Closed

Migration stay-scout-hub#137
KrishnaAgarwal7531 wants to merge 2 commits intotinyfish-io:mainfrom
KrishnaAgarwal7531:mig-stay-scout-hub

Conversation

@KrishnaAgarwal7531
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 7, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ecae37e8-b255-43ed-a3ef-1f0858b8b1b6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@simantak-dabhade simantak-dabhade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: changes requested

The README is the best-written one in this batch (mermaid diagrams, per-API usage examples, clean setup block) — but the code doesn't match what it promises. That's the headline issue.

🔴 README promises TinyFish Search + Fetch, code uses Groq hallucinations

README lines 25-53 claim:

  • /api/discover-areas uses client.search.query() + client.fetch.get_contents({ urls, format: "markdown" }) to find real travel guides and extract neighborhoods.
  • /api/discover-platforms uses client.search.query() to find booking platforms for the destination.

Actual code:

  • src/app/api/discover-areas/route.ts imports groq-sdk, prompts llama-3.3-70b-versatile for neighborhood names, falls back to a hardcoded list (generateFallbackAreas). No TinyFish call anywhere. The LLM is making up neighborhoods from training data, not extracting from real travel guides.
  • src/app/api/discover-platforms/route.ts same story — prompts Groq for platform URLs with a huge generateFallbackPlatforms hardcoded list.

Either:

  1. Make the code match the README — these two routes should actually use client.search.query + client.fetch.get_contents as documented. The README's code snippets are basically the implementation — copy them in.
  2. Rewrite the README to match the code — admit these two routes are Groq-only, drop the Search/Fetch mentions, redraw the architecture diagram.

Option 1 is much better — it's what makes this a "showcase all three TinyFish APIs" recipe. Option 2 makes the recipe way less interesting.

🔴 Build fails — static image import type error

./src/components/HeroSection.tsx:44:11
Type error: Type 'StaticImageData' is not assignable to type 'string'.

import hotelHero from '@/assets/hotel-hero.jpg' gives you Next's StaticImageData object, not a URL string. Two fixes:

  • Preferred: use Next's <Image> component (import Image from 'next/image') and <Image src={hotelHero} .../>.
  • Quick: keep the raw <img> and change to src={hotelHero.src}.

🔴 Mino still in code

Two comment references — small but explicit:

  • src/hooks/useAreaSearch.ts:36// Stage 2: Research each area in parallel via Mino
  • src/hooks/useHotelSearch.ts:39// Stage 2: Check each platform in parallel via Mino

Replace with "TinyFish" (or just "agent").

🟡 Dead src/components/ui/ dir

6 shadcn files, none imported by app code (grep for @/components/ui across src/{app,components,hooks} returns zero). Much smaller dump than other PRs in this batch so less urgent, but still worth deleting for clone-runnable cleanliness.

🟡 Nits (not blocking)

  • PR body is empty.
  • Next 15.3.3 — outdated vs pack, repo-wide sweep will handle.

✅ What's working well

  • /api/research-area/route.ts + /api/check-platform/route.ts — use SDK idiomatically.
  • README structure is genuinely excellent once the lies are fixed.
  • .env.example has URL comments for both keys.
  • No env leak.
  • 4-route architecture showing off multiple TinyFish APIs is a great recipe concept.

Fix the README/code mismatch (preferably by writing the real SDK calls), unbreak the build, purge the Mino comments, and this is a strong recipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants