Migration restaurant-comparison-tool#139
Migration restaurant-comparison-tool#139KrishnaAgarwal7531 wants to merge 2 commits intotinyfish-io:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
simantak-dabhade
left a comment
There was a problem hiding this comment.
Thanks for the Vite → Next.js App Router conversion — the core migration is clean (SDK usage, .env.example, no Mino refs, Supabase-free, CI green). Two blockers plus some cleanup nits:
Blockers
-
src/App.tsxis dead code. It's a near-byte-for-byte duplicate ofsrc/app/page.tsx(same imports, same JSX, only the function name differs —AppvsHome) and nothing in the codebase imports it. Leftover from the Vite entry point. Please delete the file. -
README never references
.env.example. Setup step atREADME.md:64says "Create a.env.localfile with your TinyFish API key" followed by an inline code block — but this PR ships a.env.exampleat the recipe root that already has the var and a helpful comment. A reader following the README won't know.env.exampleexists. Please change step 2 to something like: Copy.env.exampleto.env.localand fill in your key (cp .env.example .env.local).
Nits (fold into the same fix pass)
-
Pick one env-file convention and use it consistently. Right now the codebase mixes
.env.localin two spots (README architecture diagramREADME.md:99, API route error messagesrc/app/api/scrape/route.ts:36). Whichever you choose for blocker #2, reference that same filename in both of these. -
Sign-up link mismatch.
README.md:53links "get one here" →https://agent.tinyfish.ai(the API endpoint host), while.env.example:1correctly points tohttps://tinyfish.ai. Make the README match.env.example.
Everything else passes review. Once the above is cleaned up I'll do the local test pass and approve.
No description provided.