Skip to content

Migration restaurant-comparison-tool#139

Closed
KrishnaAgarwal7531 wants to merge 2 commits intotinyfish-io:mainfrom
KrishnaAgarwal7531:mig-resturant-comparision-tool
Closed

Migration restaurant-comparison-tool#139
KrishnaAgarwal7531 wants to merge 2 commits intotinyfish-io:mainfrom
KrishnaAgarwal7531:mig-resturant-comparision-tool

Conversation

@KrishnaAgarwal7531
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 7, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0ea92703-2b98-434e-aa88-d470635053f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@simantak-dabhade simantak-dabhade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the Vite → Next.js App Router conversion — the core migration is clean (SDK usage, .env.example, no Mino refs, Supabase-free, CI green). Two blockers plus some cleanup nits:

Blockers

  1. src/App.tsx is dead code. It's a near-byte-for-byte duplicate of src/app/page.tsx (same imports, same JSX, only the function name differs — App vs Home) and nothing in the codebase imports it. Leftover from the Vite entry point. Please delete the file.

  2. README never references .env.example. Setup step at README.md:64 says "Create a .env.local file with your TinyFish API key" followed by an inline code block — but this PR ships a .env.example at the recipe root that already has the var and a helpful comment. A reader following the README won't know .env.example exists. Please change step 2 to something like: Copy .env.example to .env.local and fill in your key (cp .env.example .env.local).

Nits (fold into the same fix pass)

  1. Pick one env-file convention and use it consistently. Right now the codebase mixes .env.local in two spots (README architecture diagram README.md:99, API route error message src/app/api/scrape/route.ts:36). Whichever you choose for blocker #2, reference that same filename in both of these.

  2. Sign-up link mismatch. README.md:53 links "get one here" → https://agent.tinyfish.ai (the API endpoint host), while .env.example:1 correctly points to https://tinyfish.ai. Make the README match .env.example.

Everything else passes review. Once the above is cleaned up I'll do the local test pass and approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants