Skip to content

fix(ai): contain provider setup errors #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
senamakel merged 8 commits into from
May 25, 2026
+23 −5
Merged

fix(ai): contain provider setup errors #2411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
266a570
fix(ai): contain provider setup errors
aqilaziz May 21, 2026
8e42b6e
Merge branch 'main' into pr/2411
senamakel May 25, 2026
06c54b1
chore(pr-fix): apply formatting
senamakel May 25, 2026
342794b
fix(i18n): remove duplicate keys in de-5.ts chunk
senamakel May 25, 2026
9ecf248
Merge remote-tracking branch 'upstream/main' into pr/2411
senamakel May 25, 2026
2894dce
Merge remote-tracking branch 'upstream/main' into pr/2411
senamakel May 25, 2026
b15a7ab
Merge remote-tracking branch 'upstream/main' into pr/2411
senamakel May 25, 2026
27fb48c
fix(i18n): restore missing customGif keys in de-5.ts chunk
senamakel May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/src/components/settings/panels/AIPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,6 @@ const ProviderKeyDialog = ({
);
};

// ─────────────────────────────────────────────────────────────────────────────
// Background loop controls + usage diagnostics
// ─────────────────────────────────────────────────────────────────────────────

Expand Down
21 changes: 20 additions & 1 deletion app/src/components/settings/panels/__tests__/AIPanel.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ vi.mock('../../../../services/api/aiSettingsApi', () => ({
saveAISettings: vi.fn(),
loadLocalProviderSnapshot: vi.fn(),
testProviderModel: vi.fn(),
setCloudProviderKey: vi.fn(),
setCloudProviderKey: vi.fn().mockResolvedValue(undefined),
clearCloudProviderKey: vi.fn().mockResolvedValue(undefined),
serializeProviderRef: vi.fn((r: { kind: string; providerSlug?: string; model?: string }) =>
r.kind === 'openhuman'
Expand Down Expand Up @@ -356,6 +356,25 @@ describe('AIPanel', () => {
expect(screen.getByLabelText(/API key/i)).toBeInTheDocument();
});

it('surfaces provider setup errors in an alert with technical details collapsed', async () => {
vi.mocked(loadAISettings).mockResolvedValue({ ...baseSettings, cloudProviders: [] });
vi.mocked(listProviderModels).mockRejectedValueOnce(
new Error('Could not reach OpenAI: provider returned 401 Unauthorized')
);

renderWithProviders(<AIPanel />);

fireEvent.click(await screen.findByRole('switch', { name: /Connect OpenAI/i }));
const dialog = await screen.findByRole('dialog', { name: /Connect OpenAI/i });
fireEvent.change(within(dialog).getByLabelText(/API key/i), {
target: { value: 'sk-bad-key' },
});
fireEvent.click(within(dialog).getByRole('button', { name: /^Save$/i }));

const alert = await within(dialog).findByRole('alert');
expect(alert).toHaveTextContent(/rejected the credentials/i);
});

it('clicking the OpenRouter chip shows both API key entry and the OAuth button', async () => {
vi.mocked(loadAISettings).mockResolvedValue({ ...baseSettings, cloudProviders: [] });

Expand Down
6 changes: 3 additions & 3 deletions app/src/lib/i18n/chunks/de-5.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,9 +241,9 @@ const de5: TranslationMap = {
'settings.mascot.characterDesc': 'Charakterbeschreibung',
'settings.mascot.characterHeading': 'Zeichenüberschrift',
'settings.mascot.customGifError':
'Gib eine HTTPS-.gif-URL, eine Loopback-HTTP-.gif-URL, eine file://-.gif-URL oder einen lokalen .gif-Pfad ein.',
'settings.mascot.customGifHeading': 'Eigener GIF-Avatar',
'settings.mascot.customGifLabel': 'URL des eigenen GIF-Avatars',
'GIF konnte nicht geladen werden. Bitte überprüfe die URL und versuche es erneut.',
'settings.mascot.customGifHeading': 'Benutzerdefinierter GIF-Avatar',
'settings.mascot.customGifLabel': 'URL für benutzerdefinierten GIF-Avatar',
'settings.mascot.colorDesc': 'Farbbeschreibung',
'settings.mascot.colorHeading': 'Farbüberschrift',
'settings.mascot.loadingLibrary': 'OpenHuman-Bibliothek wird geladen…',
Expand Down
Loading