-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add trusted external capability provider registry #2548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vaddisrinivas
wants to merge
9
commits into
tinyhumansai:main
Choose a base branch
from
vaddisrinivas:codex/oh-2541-external-capability-providers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
13f8af8
Add external capability provider registry
vaddisrinivas d91b5ef
Address provider registry review feedback
vaddisrinivas aa38c0a
Add flow-level diagnostics for provider registry build
vaddisrinivas 698a4bd
Improve external capability registry diagnostics
vaddisrinivas cc862fb
Retry CI after runner disk exhaustion
vaddisrinivas 782bf74
Merge remote-tracking branch 'upstream/main' into pr/2548
senamakel 96d4d25
Merge remote-tracking branch 'upstream/main' into pr/2548
senamakel 3f93219
test(memory): avoid pii-like tool rule fixtures
vaddisrinivas ae2859e
Wait for backend session in mega flow
vaddisrinivas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| //! Registry for external capability providers. | ||
| //! | ||
| //! This module keeps provider identity and trust metadata generic. It does not | ||
| //! know how any provider packages, loads, or executes capabilities; it only | ||
| //! normalizes the provider records OpenHuman can use for admission, policy, and | ||
| //! diagnostics. | ||
|
|
||
| mod registry; | ||
| mod types; | ||
|
|
||
| pub use registry::{normalize_provider_id, ExternalCapabilityProviderRegistry}; | ||
| pub use types::{ | ||
| ExternalCapabilityProvider, ExternalCapabilityProviderConfig, ExternalCapabilityProvidersConfig, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,258 @@ | ||
| use std::collections::BTreeMap; | ||
|
|
||
| use super::types::{ | ||
| ExternalCapabilityProvider, ExternalCapabilityProviderConfig, ExternalCapabilityProvidersConfig, | ||
| }; | ||
|
|
||
| impl ExternalCapabilityProvider { | ||
| pub(crate) fn from_config(config: &ExternalCapabilityProviderConfig) -> Result<Self, String> { | ||
| let id = normalize_provider_id(&config.id) | ||
| .ok_or_else(|| format!("invalid external capability provider id `{}`", config.id))?; | ||
| let name = config.name.trim(); | ||
| if name.is_empty() { | ||
| return Err(format!( | ||
| "external capability provider `{id}` name must be non-empty" | ||
| )); | ||
| } | ||
|
|
||
| Ok(Self { | ||
| id, | ||
| name: name.to_string(), | ||
| source_uri: trim_optional(&config.source_uri), | ||
| source_digest: trim_optional(&config.source_digest), | ||
| trusted: config.trusted, | ||
| enabled: config.enabled, | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| /// Lookup table for normalized external capability providers. | ||
| #[derive(Debug, Clone, Default)] | ||
| pub struct ExternalCapabilityProviderRegistry { | ||
| providers: BTreeMap<String, ExternalCapabilityProvider>, | ||
| errors: Vec<String>, | ||
| } | ||
|
|
||
| impl ExternalCapabilityProviderRegistry { | ||
| /// Build a registry from config, collecting invalid records as errors. | ||
| pub fn from_config(config: &ExternalCapabilityProvidersConfig) -> Self { | ||
| let total_providers = config.providers.len(); | ||
| log::debug!( | ||
| "[external_capability][registry] build_start total_providers={}", | ||
| total_providers | ||
| ); | ||
| let mut providers = BTreeMap::new(); | ||
| let mut errors = Vec::new(); | ||
| let mut accepted_count = 0usize; | ||
| let mut rejected_count = 0usize; | ||
| let mut duplicate_count = 0usize; | ||
|
|
||
| for provider in &config.providers { | ||
| match ExternalCapabilityProvider::from_config(provider) { | ||
| Ok(provider) => { | ||
| if providers.contains_key(&provider.id) { | ||
| duplicate_count += 1; | ||
| rejected_count += 1; | ||
| log::debug!( | ||
| "[external_capability][registry] provider_duplicate provider_id={} total_providers={} accepted_count={} rejected_count={} duplicate_count={}", | ||
| provider.id, | ||
| total_providers, | ||
| accepted_count, | ||
| rejected_count, | ||
| duplicate_count | ||
| ); | ||
| errors.push(format!( | ||
| "duplicate external capability provider id `{}`", | ||
| provider.id | ||
| )); | ||
| } else { | ||
| accepted_count += 1; | ||
| log::debug!( | ||
| "[external_capability][registry] provider_accepted provider_id={} trusted={} enabled={} total_providers={} accepted_count={} rejected_count={} duplicate_count={}", | ||
| provider.id, | ||
| provider.trusted, | ||
| provider.enabled, | ||
| total_providers, | ||
| accepted_count, | ||
| rejected_count, | ||
| duplicate_count | ||
| ); | ||
| providers.insert(provider.id.clone(), provider); | ||
| } | ||
| } | ||
| Err(err) => { | ||
| rejected_count += 1; | ||
| log::debug!( | ||
| "[external_capability][registry] provider_rejected provider_config_id={} error={} total_providers={} accepted_count={} rejected_count={} duplicate_count={}", | ||
| provider.id, | ||
| err, | ||
| total_providers, | ||
| accepted_count, | ||
| rejected_count, | ||
| duplicate_count | ||
| ); | ||
| errors.push(err); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| let provider_ids = providers.keys().cloned().collect::<Vec<_>>(); | ||
| log::debug!( | ||
| "[external_capability][registry] build_end total_providers={} accepted_count={} rejected_count={} duplicate_count={} error_count={} provider_ids={:?} errors={:?}", | ||
| total_providers, | ||
| accepted_count, | ||
| rejected_count, | ||
| duplicate_count, | ||
| errors.len(), | ||
| provider_ids, | ||
| errors | ||
| ); | ||
|
|
||
| Self { providers, errors } | ||
| } | ||
|
|
||
| /// Whether the registry has no valid providers. | ||
| pub fn is_empty(&self) -> bool { | ||
| self.providers.is_empty() | ||
| } | ||
|
|
||
| /// List valid providers in normalized id order. | ||
| pub fn list(&self) -> Vec<&ExternalCapabilityProvider> { | ||
| self.providers.values().collect() | ||
| } | ||
|
|
||
| /// Get a provider by raw or normalized id. | ||
| pub fn get(&self, provider_id: &str) -> Option<&ExternalCapabilityProvider> { | ||
| normalize_provider_id(provider_id).and_then(|id| self.providers.get(&id)) | ||
| } | ||
|
|
||
| /// Whether a provider is known, enabled, and trusted. | ||
| pub fn can_register_tools(&self, provider_id: &str) -> bool { | ||
| self.get(provider_id) | ||
| .map(ExternalCapabilityProvider::can_register_tools) | ||
| .unwrap_or(false) | ||
| } | ||
|
|
||
| /// Config load errors for invalid or duplicate provider records. | ||
| pub fn errors(&self) -> &[String] { | ||
| &self.errors | ||
| } | ||
| } | ||
|
|
||
| /// Normalize and validate an external capability provider id. | ||
| pub fn normalize_provider_id(value: &str) -> Option<String> { | ||
| let normalized = value.trim().to_ascii_lowercase(); | ||
| if normalized.is_empty() { | ||
| return None; | ||
| } | ||
| let valid = normalized | ||
| .chars() | ||
| .all(|ch| ch.is_ascii_lowercase() || ch.is_ascii_digit() || matches!(ch, '-' | '_' | '.')); | ||
| if !valid { | ||
| return None; | ||
| } | ||
| let starts_or_ends_with_sep = normalized | ||
| .chars() | ||
| .next() | ||
| .zip(normalized.chars().last()) | ||
| .map(|(first, last)| is_separator(first) || is_separator(last)) | ||
| .unwrap_or(true); | ||
| if starts_or_ends_with_sep { | ||
| return None; | ||
| } | ||
| Some(normalized) | ||
| } | ||
|
|
||
| fn is_separator(ch: char) -> bool { | ||
| matches!(ch, '-' | '_' | '.') | ||
| } | ||
|
|
||
| fn trim_optional(value: &Option<String>) -> Option<String> { | ||
| value | ||
| .as_deref() | ||
| .map(str::trim) | ||
| .filter(|value| !value.is_empty()) | ||
| .map(str::to_string) | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
|
|
||
| fn config(id: &str) -> ExternalCapabilityProviderConfig { | ||
| ExternalCapabilityProviderConfig { | ||
| id: id.to_string(), | ||
| name: "Local Runtime".to_string(), | ||
| source_uri: Some(" file:///runtime ".to_string()), | ||
| source_digest: Some(" sha256:abc ".to_string()), | ||
| trusted: true, | ||
| enabled: true, | ||
| } | ||
| } | ||
|
|
||
| #[test] | ||
| fn normalizes_valid_provider_ids() { | ||
| assert_eq!( | ||
| normalize_provider_id(" Local.Runtime_1 "), | ||
| Some("local.runtime_1".to_string()) | ||
| ); | ||
| assert_eq!( | ||
| normalize_provider_id("provider-1"), | ||
| Some("provider-1".to_string()) | ||
| ); | ||
| } | ||
|
|
||
| #[test] | ||
| fn rejects_invalid_provider_ids() { | ||
| assert_eq!(normalize_provider_id(""), None); | ||
| assert_eq!(normalize_provider_id(".provider"), None); | ||
| assert_eq!(normalize_provider_id("provider."), None); | ||
| assert_eq!(normalize_provider_id("provider id"), None); | ||
| assert_eq!(normalize_provider_id("provider/id"), None); | ||
| } | ||
|
|
||
| #[test] | ||
| fn registry_loads_trusted_enabled_provider() { | ||
| let registry = | ||
| ExternalCapabilityProviderRegistry::from_config(&ExternalCapabilityProvidersConfig { | ||
| providers: vec![config("runtime.local")], | ||
| }); | ||
|
|
||
| assert!(registry.errors().is_empty()); | ||
| assert_eq!(registry.list().len(), 1); | ||
| assert!(registry.can_register_tools("RUNTIME.LOCAL")); | ||
| let provider = registry.get("runtime.local").unwrap(); | ||
| assert_eq!(provider.source_uri.as_deref(), Some("file:///runtime")); | ||
| assert_eq!(provider.source_digest.as_deref(), Some("sha256:abc")); | ||
| } | ||
|
|
||
| #[test] | ||
| fn disabled_or_untrusted_provider_cannot_register_tools() { | ||
| let mut disabled = config("disabled.runtime"); | ||
| disabled.enabled = false; | ||
| let mut untrusted = config("untrusted.runtime"); | ||
| untrusted.trusted = false; | ||
| let registry = | ||
| ExternalCapabilityProviderRegistry::from_config(&ExternalCapabilityProvidersConfig { | ||
| providers: vec![disabled, untrusted], | ||
| }); | ||
|
|
||
| assert!(!registry.can_register_tools("disabled.runtime")); | ||
| assert!(!registry.can_register_tools("untrusted.runtime")); | ||
| } | ||
|
|
||
| #[test] | ||
| fn registry_reports_duplicates_and_invalid_records() { | ||
| let mut unnamed = config("unnamed.runtime"); | ||
| unnamed.name = " ".to_string(); | ||
| let registry = | ||
| ExternalCapabilityProviderRegistry::from_config(&ExternalCapabilityProvidersConfig { | ||
| providers: vec![config("runtime.local"), config("RUNTIME.LOCAL"), unnamed], | ||
| }); | ||
|
|
||
| assert_eq!(registry.list().len(), 1); | ||
| assert_eq!(registry.errors().len(), 2); | ||
| assert!(registry.errors()[0].contains("duplicate")); | ||
| assert!(registry.errors()[1].contains("name must be non-empty")); | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.