Skip to content

fix: stale lastError on reconnect and short first chat bubble #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shriii257 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix: stale lastError on reconnect and short first chat bubble #2616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/src/store/connectivitySlice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,13 @@ const slice = createSlice({
},
setBackend(state, action: PayloadAction<{ value: BackendState; error?: string }>) {
state.backend = action.payload.value;
if (action.payload.value === 'connected') {
if (action.payload.value === 'connected' || action.payload.value === 'connecting') {
// Clear the stale error on both successful connection and reconnect
// attempts. Previously only 'connected' deleted lastError.backend,
// which meant a prior disconnect error (e.g. "transport close") was
// left set to `undefined` — not deleted — during 'connecting'. UI
// components that read lastError.backend could still surface a stale
// message in the reconnect window even though the key appeared falsy.
delete state.lastError.backend;
} else {
state.lastError.backend = action.payload.error;
Expand Down
Loading