feat(about_app): catalog entries for embedding provider selection (#2583 follow-up)#2656
Open
justinhsu1477 wants to merge 1 commit into
Open
Conversation
…nyhumansai#2583 follow-up) Closes the explicit follow-up listed in the tinyhumansai#2583 PR body: > Follow-up: about_app capability catalog entries for embeddings provider > selection tinyhumansai#2583 added Settings > AI > Embeddings — users can now pick between managed cloud (Voyage), OpenAI, Cohere, local Ollama, or a custom OpenAI-compatible endpoint, with per-provider API key, model, and dimension knobs. The in-app feature catalog (about_app::catalog) is how those affordances become discoverable to the user (via Settings search), to other agents (via `openhuman.about_app_capabilities`), and to the in-app Privacy surface (via per-capability `privacy` metadata). Without an entry, the new panel is invisible to that whole layer. Two new capability records under the `embeddings` domain, slotted in the Intelligence category so they sit alongside `memory_tree_retrieval` / `mcp_server` rather than getting orphaned in a fresh domain bucket: * `intelligence.embedding_provider_config` — the Settings panel itself. Privacy: `LOCAL_CREDENTIALS` (API keys are written to the local keyring under `embeddings:<slug>` and never leave the device). * `intelligence.embedding_provider_test` — the "Test Connection" action. Privacy: `DERIVED_TO_BACKEND` (a small probe payload is sent to whichever provider is selected; default = OpenHuman backend / TinyHumans Neocortex via Voyage). The split (config = local credentials, test = derived-to-backend) matters because the Privacy surface in-app aggregates per-capability annotations to answer "what leaves my computer when I touch this screen?". Collapsing both into a single annotation under-reports one of the two flows. Tests (3 new in `about_app::catalog::tests`, 23/23 pass): * `catalog_includes_additional_user_facing_surfaces` extended with both new ids. * `embedding_provider_capabilities_share_domain_and_category` pins both to `domain = "embeddings"`, asserts same category, and pins the `how_to` breadcrumbs at "Settings > … > Embeddings" so a UI move surfaces here. * `embedding_provider_capabilities_split_privacy_correctly` asserts config has `leaves_device == false` and test has `leaves_device == true` — defends against an accidental consolidation that would flatten the two privacy signals. No production-code changes — pure metadata addition. `cargo check --lib` + `cargo fmt --check` + `cargo test --tests --no-run` all clean.
Contributor
📝 WalkthroughWalkthroughThis PR adds two embedding provider capabilities ( ChangesEmbedding Provider Capabilities
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
Bot
added
feature
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/openhuman/about_app/catalog.rs`:
- Around line 332-339: The privacy destinations currently set to
DERIVED_TO_BACKEND under-represent that the probe text can be sent to external
model providers (OpenAI, Cohere, custom endpoints); change the privacy
declaration for this capability (the privacy field next to status and the
CapabilityStatus::Beta line) to include external/model destinations in addition
to DERIVED_TO_BACKEND—e.g., add the existing DERIVED_TO_MODEL or
DERIVED_TO_THIRD_PARTY flag (or define and add a new DERIVED_TO_EXTERNAL
destination in the privacy enum if missing) so the catalog accurately records
that the probe may leave the backend to third‑party model endpoints.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b8b2f868-d12b-482e-b4bc-0b3806c1b041
📒 Files selected for processing (2)
src/openhuman/about_app/catalog.rssrc/openhuman/about_app/catalog_tests.rs
Comment on lines
+332
to
+339
| // Test payload is a short fixed string ('OpenHuman connectivity \ | ||
| // probe'-style) sent to whichever provider is selected — Voyage via \ | ||
| // the OpenHuman backend, OpenAI, Cohere, or a custom endpoint. \ | ||
| // `DERIVED_TO_BACKEND` is the right label for the default (managed \ | ||
| // cloud) path; the destination list reflects that this is *derived* \ | ||
| // signal (the probe text), not raw user content. | ||
| status: CapabilityStatus::Beta, | ||
| privacy: DERIVED_TO_BACKEND, |
Contributor
There was a problem hiding this comment.
Privacy destinations are too narrow for multi-provider test flow.
At Line 332-335 the description says the probe may go to OpenAI/Cohere/custom endpoints, but Line 339 uses DERIVED_TO_BACKEND (destinations only backend/neocortex). This under-reports possible off-device destinations in the privacy catalog.
Suggested fix
+const DERIVED_TO_CONFIGURED_EMBEDDING_PROVIDER: Option<CapabilityPrivacy> = Some(CapabilityPrivacy {
+ leaves_device: true,
+ data_kind: PrivacyDataKind::Derived,
+ destinations: &[
+ "OpenHuman backend (managed cloud)",
+ "Configured embedding provider endpoint (e.g., OpenAI/Cohere/custom)",
+ ],
+});
...
- privacy: DERIVED_TO_BACKEND,
+ privacy: DERIVED_TO_CONFIGURED_EMBEDDING_PROVIDER,📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // Test payload is a short fixed string ('OpenHuman connectivity \ | |
| // probe'-style) sent to whichever provider is selected — Voyage via \ | |
| // the OpenHuman backend, OpenAI, Cohere, or a custom endpoint. \ | |
| // `DERIVED_TO_BACKEND` is the right label for the default (managed \ | |
| // cloud) path; the destination list reflects that this is *derived* \ | |
| // signal (the probe text), not raw user content. | |
| status: CapabilityStatus::Beta, | |
| privacy: DERIVED_TO_BACKEND, | |
| const DERIVED_TO_CONFIGURED_EMBEDDING_PROVIDER: Option<CapabilityPrivacy> = Some(CapabilityPrivacy { | |
| leaves_device: true, | |
| data_kind: PrivacyDataKind::Derived, | |
| destinations: &[ | |
| "OpenHuman backend (managed cloud)", | |
| "Configured embedding provider endpoint (e.g., OpenAI/Cohere/custom)", | |
| ], | |
| }); | |
| // Test payload is a short fixed string ('OpenHuman connectivity \ | |
| // probe'-style) sent to whichever provider is selected — Voyage via \ | |
| // the OpenHuman backend, OpenAI, Cohere, or a custom endpoint. \ | |
| // `DERIVED_TO_BACKEND` is the right label for the default (managed \ | |
| // cloud) path; the destination list reflects that this is *derived* \ | |
| // signal (the probe text), not raw user content. | |
| status: CapabilityStatus::Beta, | |
| privacy: DERIVED_TO_CONFIGURED_EMBEDDING_PROVIDER, |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/openhuman/about_app/catalog.rs` around lines 332 - 339, The privacy
destinations currently set to DERIVED_TO_BACKEND under-represent that the probe
text can be sent to external model providers (OpenAI, Cohere, custom endpoints);
change the privacy declaration for this capability (the privacy field next to
status and the CapabilityStatus::Beta line) to include external/model
destinations in addition to DERIVED_TO_BACKEND—e.g., add the existing
DERIVED_TO_MODEL or DERIVED_TO_THIRD_PARTY flag (or define and add a new
DERIVED_TO_EXTERNAL destination in the privacy enum if missing) so the catalog
accurately records that the probe may leave the backend to third‑party model
endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the explicit follow-up listed in #2583's PR body:
#2583 added Settings > AI > Embeddings — users can now pick between managed cloud (Voyage), OpenAI, Cohere, local Ollama, or a custom OpenAI-compatible endpoint, with per-provider API key + model + dimension knobs. The in-app feature catalog (`about_app::catalog`) is how those affordances become discoverable to:
Without an entry, the new panel is invisible to that whole layer.
What's added
Two capability records under the new `embeddings` domain, slotted into the Intelligence category so they sit alongside `memory_tree_retrieval` / `mcp_server` rather than getting orphaned in a fresh domain bucket.
The privacy split matters: the in-app Privacy surface aggregates per-capability annotations to answer "what leaves my computer when I touch this screen?". Collapsing both into one annotation under-reports the probe-time network call.
Tests
3 new tests added to `src/openhuman/about_app/catalog_tests.rs`, all 23/23 pass:
Test plan
Pure metadata addition — no production-code change beyond two new const records and a regression test trio.
Refs #2583.
Summary by CodeRabbit
New Features
Tests