revert: remove all Sentry error suppression from PRs #2813 #2850 #2899 #2906 #2915 #2923 #2924 #2928 #2930 #2934 #2937 #2939

[graycyrus]

Summary

Removes all Sentry error suppression code added by the following PRs, restoring original error reporting behavior so errors properly fire Sentry events again:

• fix(inference): suppress Sentry noise when ollama model doesn't support tools #2813 — config_rejection.rs: 5 tool-unsupported phrases + tests
• fix(observability): demote memory-store PII rejection errors from Sentry to warn #2850 — observability.rs: MemoryStorePiiRejection variant + is_memory_store_pii_rejection() + tests
• fix(observability): suppress 429/rate-limit Sentry noise — TAURI-RUST-3 #2899 — observability.rs: is_upstream_rate_limit_message() + tests; provider/ops.rs: rate-limit body guard in api_error + tests
• fix(subconscious): suppress repeated Sentry noise when DB init fails (TAURI-RUST-A, closes #2903) #2906 — subconscious/store.rs: doc comment + error message text change
• fix(observability): suppress VOYAGE_API_KEY not configured Sentry noise (#2912) #2915 — observability.rs: "_api_key is not configured" phrase extension to ApiKeyMissing check + test
• fix(observability): demote ollama daemon-unreachable to expected error (TAURI-RUST-B / #2921) #2923 — memory_store/factories.rs: updated comment + tauri_rust_b_wire_shape_classifies_as_expected test
• fix(observability): suppress billing 401 Sentry noise (TAURI-RUST-E, #2922) #2924 — observability.rs: "backend rejected session token" phrase in is_session_expired_message() + tests
• fix(observability): demote expected chat failures out of Sentry (TAURI-RUST-68, closes #2926) #2928 — inference/ops.rs: is_expected_chat_failure() helper + conditional demotion in inference_test_provider_model; ops_tests.rs: 4 tests
• fix(observability): suppress composio-direct HTTP 403 Sentry noise (TAURI-RUST-322) #2930 — observability.rs: http 403 extension to composio-direct auth wall matcher + tests
• fix(observability): suppress embeddings API-key 401 Sentry noise (CORE-RUST-EK) #2934 — observability.rs: is_embeddings_api_key_401_event() + tests; main.rs: embeddings 401 before_send filter
• fix(observability): extend is_budget_event to text-only tier-2 match (OPENHUMAN-CORE-N / #2935) #2937 — observability.rs: text-only tier-2 is_budget_event + tests
• fix(inference): return empty model list on 404 from /models endpoint #2939 — provider/ops.rs: 404 empty-list return in list_configured_models_from_config + test

These PRs suppressed/demoted errors instead of fixing root causes. Errors will now properly fire Sentry events again so they can be tracked and fixed with proper root-cause solutions.

Test plan

• cargo check passes (verified locally — only pre-existing warnings, no errors)
• Errors from the above categories now surface in Sentry for proper root-cause investigation

Summary by CodeRabbit

• Bug Fixes

  • Refined error classification and reporting logic for improved observability.
  • Adjusted provider error handling to report failures more consistently.
  • Updated error message filtering to more accurately categorize and surface error events.

• Refactor

  • Streamlined internal error classification patterns and removed redundant suppression layers.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 099f77cd-bee7-4077-8808-a0354c203cae

📥 Commits

Reviewing files that changed from the base of the PR and between b7110d0 and 34ed335.

📒 Files selected for processing (8)

• src/core/observability.rs
• src/main.rs
• src/openhuman/inference/ops.rs
• src/openhuman/inference/ops_tests.rs
• src/openhuman/inference/provider/config_rejection.rs
• src/openhuman/inference/provider/ops.rs
• src/openhuman/memory_store/factories.rs
• src/openhuman/subconscious/store.rs

---

📝 Walkthrough

Walkthrough

This PR systematically removes error suppression and demotion filters across the observability, Sentry, and provider/inference layers. Changes narrow classification logic for expected errors, remove tagless/defense-in-depth suppression filters, eliminate conditional error demotions, and allow previously filtered errors to surface in Sentry reporting.

Changes

Error reporting classification and suppression removal

Layer / File(s)	Summary
Core expected-error-kind enum and matching logic tightening src/core/observability.rs	Removes the MemoryStorePiiRejection expected-kind variant and its classification/reporting paths; narrows ApiKeyMissing detection by removing backend env-var phrase matching; updates classification boundaries. Unit tests for PII rejection and API-key env-var matching are removed and replaced with negative assertions.
Session-expired and provider user-state classification narrowing src/core/observability.rs	Removes billing 401 backend rejected session token from session-expired classification; tightens [composio-direct] HTTP 403 demotion to HTTP 401 only. Tests validating composio 403 demotion and billing 401→session-expired classification are removed.
Budget event filtering logic rewrite src/core/observability.rs	Rewrites is_budget_event to require both failure == "non_2xx" and status == "400" tags, removing the previous tagless "Insufficient budget" phrase-based suppression tier. Tests validating tagless suppression and exception-path drops are removed.
Sentry before_send defense-in-depth filter removal src/main.rs	Removes two before_send suppression blocks that previously dropped embeddings HTTP 401 "api-key" events and upstream rate-limit detection, allowing those events to pass through to Sentry.
Inference expected-failure classification removal src/openhuman/inference/ops.rs, src/openhuman/inference/ops_tests.rs	Removes the is_expected_chat_failure ops-layer classifier; simplifies inference_test_provider_model error handling to log all failures uniformly as errors instead of conditionally demoting expected failures to warnings. Entire test suite for expected-failure matchers is removed.
Provider config rejection phrase matching tightening src/openhuman/inference/provider/config_rejection.rs	Removes tool-calling/tool-parameter "does not support tools" phrase family from is_provider_config_rejection_message; keeps and expands user-state matchers for model-field errors, thinking-mode rejection, and Ollama subscription gating. Tool-unsupported test coverage is removed.
Provider /models 404 handling and api_error Sentry reporting changes src/openhuman/inference/provider/ops.rs	Removes the /models HTTP 404 special-case that returned empty list with unsupported=true; changes api_error non-2xx Sentry reporting to unconditionally report with tags instead of suppressing when rate-limit phrases are detected in non-429 responses. Tests for 404 and rate-limit suppression are removed.
Supporting documentation and minor updates src/openhuman/memory_store/factories.rs, src/openhuman/subconscious/store.rs	Updates Ollama health-gate error reporting documentation; removes associated classification test; removes with_connection doc comment describing init-failure suppression; updates error context message for directory creation from generic to "failed to create subconscious dir".

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related PRs

• tinyhumansai/openhuman#2850: This PR directly reverses the addition of ExpectedErrorKind::MemoryStorePiiRejection and its suppression behavior by removing the entire classification path.
• tinyhumansai/openhuman#2928: Both PRs directly modify src/openhuman/inference/ops.rs to change how inference errors are classified and logged by removing the "expected chat failure" demotion.
• tinyhumansai/openhuman#2939: Both PRs modify the same /models HTTP 404 handling in list_configured_models_from_config (this PR removes the special-case empty-list behavior).

Suggested labels

rust-core, sentry-traced-bug, working, bug

Suggested reviewers

• oxoxDev
• M3gA-Mind

Poem

🐰 A rabbit hops through observability's brush,
Sweeping away the filters and suppression rush—
Expected kinds shrink, and errors now rise,
More truths reach Sentry beneath the code skies!
No more silent demotions in darkness to hide,
Just clear error signals flowing free and wide. ✨

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[graycyrus]

Closing — this was created by a stale agent on the wrong branch. The correct revert PR will come from the worktree.