Conversation
erickzhao
changed the title
log-table a functional component
erickzhao
changed the title
VerteDinde
approved these changes
Mar 25, 2026
samuelmaddock
approved these changes
Mar 25, 2026
Contributor
samuelmaddock
left a comment
samuelmaddock
left a comment
There was a problem hiding this comment.
I see a few cases where componentDidMount were refactored to useEffect with dependencies. This may cause component initialization logic to run multiple times.
If sleuth seems to behave normally, it's probably fine to merge.
| return () => { | ||
| unmountListener(); | ||
| }; | ||
| }, [props.state]); |
Contributor
There was a problem hiding this comment.
Doesn't seem like an exact match to the previous componentDidMount behavior, but it might be fine? This will cause Sleuth.setupSuggestionsUpdated to be called multiple times whenever props.state changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit difficult to review but I mostly spot checked to validate the output.
The most crucial component here is
log-table.tsx, which was previously usingUNSAFE_componentWillReceivePropsto handle state updates.(Most of the other ones are trivial.)