Migrate fast interpreter gen to use macro assembler #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-mojira
changed the title
titzer
reviewed
Jan 29, 2026
| genCopyStackValsToVfp(cnt, r_tmp1); | ||
| // Deallocate interpreter frame and return to calling code. | ||
| asm.movd_r_i(Target.V3_RET_GPRS[0], 0); | ||
| asm.movd_r_i(G(Target.V3_RET_GPRS[0]), 0); |
Owner
There was a problem hiding this comment.
There are a lot of methods in MacroAssembler for emitting a constant into a register. I think emit_mov_r_i will do here.
| saveCallerIVars(); | ||
| callRuntime(refRuntimeCall(X86_64RT.runtime_checkFuncSigSubtyping), [r_instance, sig_index, r_func_arg], false); | ||
| asm.movq_r_r(r_func_arg, Target.V3_RET_GPRS[0]); | ||
| asm.movq_r_r(r_func_arg, G(Target.V3_RET_GPRS[0])); |
Owner
There was a problem hiding this comment.
There is masm.emit_mov_r_r(kind, reg, reg) for this one.
| asm.q.add_r_r(r_stp, handler_length); | ||
| } | ||
| private def adjustSp(size: int) { | ||
| if (size > 0) { |
Owner
There was a problem hiding this comment.
I think we should let the macro assembler do this check for negative sizes. IIRC the 1-byte addi on intel will do sign extension, which will make it smaller than subi for negative values that fit in one byte.
| def TRAPS_STUB = X86_64SpcTrapsStub.new(); | ||
| def TRAPS_PREGEN = X86_64PreGenStub.new("spc-trap", TRAPS_STUB, genTrapsStub); | ||
|
|
||
| def genSpcEntryFunc(ic: X86_64InterpreterCode, w: DataWriter) { |
Owner
There was a problem hiding this comment.
In a follow-up PR, we might be able to pull this up to the arch-independent part of SPC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.