Update redis commands to use array notation#9
Merged
noamshemesh merged 1 commit intotj:masterfrom Jan 10, 2015
Merged
Conversation
ruimarinho
force-pushed
the
enhancement/use-array-args-for-redis-commands
branch
from
dbbd1cb to
fc6ea0e
Compare
This is a small performance improvement since the `redis` module offers a straight passthrough mode for command callbacks, since it does not rely on parsing `arguments`.
ruimarinho
force-pushed
the
enhancement/use-array-args-for-redis-commands
branch
from
fc6ea0e to
8e01ba9
Compare
ruimarinho
changed the title
watch and mget to use array arguments
Contributor
|
Nice! |
Contributor
Author
|
Any chance of taking a look at this @noamshemesh? |
Collaborator
|
That looks awesome! I probably will merge it on this weekend. |
noamshemesh
pushed a commit
that referenced
this pull request
Jan 10, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small performance improvement since the
redismodule offersa straight passthrough mode for command callbacks, since it does not
rely on parsing
arguments.