Skip to content

fix(ui): consistency when rejecting/approving events#1830

Open
ZamanZahid wants to merge 3 commits intotjcsl:devfrom
ZamanZahid:dev
Open

fix(ui): consistency when rejecting/approving events#1830
ZamanZahid wants to merge 3 commits intotjcsl:devfrom
ZamanZahid:dev

Conversation

@ZamanZahid
Copy link
Copy Markdown

closes #1825

Proposed changes

  • keeps ?show=all, after approve/reject

@ZamanZahid ZamanZahid requested a review from a team as a code owner September 14, 2025 01:50
@coveralls
Copy link
Copy Markdown

coveralls commented Sep 14, 2025

Coverage Status

coverage: 79.255% (-0.1%) from 79.398%
when pulling 4785c7f on ZamanZahid:dev
into aacf793 on tjcsl:dev.

Copy link
Copy Markdown
Member

@aarushtools aarushtools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution is innovative, but can you use request.GET.urlencode() and just add that to the url instead. It's more verbose and http_referer could have bad input. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix UI consistency when rejecting/approving events

3 participants