feat(eighth): Allow 8th period activities to be scheduled but not seen#1866
feat(eighth): Allow 8th period activities to be scheduled but not seen#1866ElijahFeldman7 wants to merge 1 commit intotjcsl:devfrom
Conversation
aa77ea6 to
0dee7d4
Compare
shrysjain
left a comment
There was a problem hiding this comment.
Hi Elijah, good work so far! A couple changes to make:
Right now, when an activity is marked as hidden it does not show up for students in the eighth signup page, but the block can still be seen from the activity page (eighth/activity/<id>). Through this students can also sign up for hidden activities which defeats the purpose. Can you make it so the scheduled block is also not visible here until the appropriate date has passed?
This block has the activity marked as hidden and is not visible from signup but is visible from the activity page when logged in as a student
Also, the functionality for adding a "hidden until" date in eighth admin (eighth/admin/scheduling/schedule) seems to work, but after clicking the save button the date no longer shows in the text area whereas things like comments, checkmarks, e.t.c. do persist. Can you figure out why this is happening and fix that as well.
I set a hidden until date and saved but it does not show
Other than that, great work and this should be pretty close to being complete :)
|
i think these should be fixed now ^, lmk if you want any other changes |
aarushtools
left a comment
There was a problem hiding this comment.
Hi Elijah,
Good work on this issue so far, just a few more things on top of what Shreyas said:

Can you format this tooltip text to separate the date and time better (and on a 12 HR clock). Also, the hidden badge has the same color as 2-day - can you make it have a unique styling (but use bland colors)
Also, can you prevent add_user from going through if the activity is hidden
|
ok this should be good now; i made the icon grey btw |
Proposed changes
Brief description of rationale
closes #1863