fix(ip-allowlisting): correct onEvaluationError default from ALLOW to DENY#640
Open
grahamritter wants to merge 1 commit intoip-allowlistingfrom
Open
fix(ip-allowlisting): correct onEvaluationError default from ALLOW to DENY#640grahamritter wants to merge 1 commit intoip-allowlistingfrom
grahamritter wants to merge 1 commit intoip-allowlistingfrom
Conversation
… DENY Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fainashalts
approved these changes
Apr 24, 2026
fainashalts
left a comment
fainashalts
left a comment
There was a problem hiding this comment.
looks good to me, thanks Graham!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onEvaluationErrordefault value fromALLOWtoDENY, which matches the actual implementation inset_v1.go, the DB schema (DEFAULT 'DENY'), andApplyDefaults()in the model layerTest plan
DENY" on the IP allowlisting page🤖 Generated with Claude Code