Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
b1f4eaa to
3f55871
Compare
…dded shared folder to CI for checks as well
0a0c51a to
1ce6c90
Compare
andrewkmin
reviewed
Feb 3, 2026
leeland-turnkey
commented
Feb 3, 2026
|
|
||
| This page is hosted at https://oauth-redirect.turnkey.com/ | ||
|
|
||
| # Subfolders and build status |
Contributor
Author
There was a problem hiding this comment.
AI helped with this @andrewkmin
context: #112 (comment)
andrewkmin
approved these changes
Feb 3, 2026
Contributor
There was a problem hiding this comment.
Nonblocking, and not related to this PR but just some additional documentation suggestions: we could add to the verifyEnclaveSignature function signature in line ~44 or ~61:
// Read environment from meta tag (templated at deploy time), fall back to window variable (for testing)
-->
// Read environment from meta tag, fall back to window variable (for testing).
// Additional context: this iframe uses SRI (the browser verifies JS bundle hashes at load time).
// If we templated the environment variable directly in JS (like the shared module does), the
// `sed` replacement at deploy time would change the bundle content, invalidating the SRI hash
// and causing the browser to block the script. By reading from a meta tag, we can template
// the HTML without touching the JS bundle, preserving SRI integrity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate Shared Code into
shared/FolderProblem
There was significant code duplication between
export-and-sign,import, and other frames. This led to:Solution
Created a new
shared/folder containing common utilities used across all frames, following the recommendation to "unify the code between all frames by extracting shared code into reusable libraries."Changes
Updated Frames to Use Shared Code
export-and-sign:
turnkey-core.jsto import from shared and keep frame-specific code (Ed25519, verifyEnclaveSignature using @turnkey/crypto)crypto-utils.jsto re-export from shared@sharedaliasimport:
turnkey-core.jsto import from shared and keep frame-specificapplySettingslogicindex.jsandstandalone.jsto use sharedHpkeEncrypt@sharedaliasAdded CI for Shared Folder
sharedto CI matrix for tests, linting, and formatting