Open
Conversation
andrewkmin
commented
Aug 7, 2024
| }).toThrow("number cannot fit in a hex string of 2 characters"); | ||
| }); | ||
|
|
||
| it("contains bigIntToBase64Url", () => { |
Contributor
Author
There was a problem hiding this comment.
the rest of the above is formatting; this is the net-new test suite collection that needs review :)
Contributor
Author
There was a problem hiding this comment.
here's a separate PR to deal with just prettifying: #50
zkharit
reviewed
Aug 8, 2024
| expect(() => { TKHQ.bigIntToHex(BigInt(256), 2) }).toThrow("number cannot fit in a hex string of 2 characters"); | ||
| }) | ||
| expect(() => { | ||
| TKHQ.bigIntToHex(BigInt(256), 2); |
Contributor
There was a problem hiding this comment.
want to add a similar expect(TKHQ.bigIntToBase64Url(BigInt(255), 2)).toThrow("number cannot fit in a hex string of 2 characters"); under the other bigIntToBase64Url tests for completeness?
zkharit
approved these changes
Aug 8, 2024
zkharit
previously approved these changes
Aug 8, 2024
omkarshanbhag
previously approved these changes
Aug 8, 2024
andrewkmin
force-pushed
the
andrew/test-int-base64url
branch
from
ebfd9da to
52baccc
Compare
andrewkmin
force-pushed
the
andrew/test-int-base64url
branch
from
52baccc to
2316ccd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$title
also formats the test file. perhaps format everything (e.g. via
prettier) in a separate, standalone PR