Note severity - #13
Open
canadaduane wants to merge 2 commits into
Open
Conversation
canadaduane
commented
Oct 15, 2020
| ); | ||
| break; | ||
| default: | ||
| if (showGutterIcon) { |
Author
There was a problem hiding this comment.
I'm not sure if this is the right behavior. I can see two possibilities:
- the
showGutterIconsetting should be absolute & final, i.e. NO gutter icons whatsoever - OR the
showGutterIconshould be for default icons. If the user adds severity hashtags in the note, the presence of the tag overrides theshowGutterIconsetting.
I've implemented the latter.
Author
|
There is currently a bug in this PR that makes all notes the color of the highest severity note :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7