Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1116 commits
Select commit Hold shift + click to select a range
3cfabaf
fix typo
wonda-tea-coffee Jun 8, 2022
229743d
Merge pull request #2609 from wonda-tea-coffee/fix-typo
thiagofm Jun 16, 2022
7e947ba
Suppress rspec deprecation
wonda-tea-coffee Jun 18, 2022
00678db
delete unnecessary alias
wonda-tea-coffee Jun 18, 2022
6bf0de8
delete unnecessary class
wonda-tea-coffee Jun 18, 2022
27ee8af
add rspec config raise_errors_for_deprecations!
wonda-tea-coffee Jun 18, 2022
bbaa006
Merge pull request #2612 from wonda-tea-coffee/patch-1
mshibuya Jun 18, 2022
cdc14f8
Set `:content_type` in `copy_options` for GCS.
smnscp Jun 27, 2022
5e5ee96
Fix content type detection for JSON files.
smnscp Jul 8, 2022
0657941
Merge pull request #2618 from smnscp/fix-content-type-detection-for-json
thiagofm Jul 14, 2022
90d2cae
Fixed non-existent branch name
wonda-tea-coffee Jul 19, 2022
774c63d
Merge pull request #2620 from wonda-tea-coffee/patch-3
mshibuya Jul 19, 2022
36dac97
Restored the condition to execute write_uploader
wonda-tea-coffee Jun 18, 2022
d98e974
Merge pull request #2613 from wonda-tea-coffee/patch-2
mshibuya Jul 20, 2022
807e743
Apply suggestions from code review.
smnscp Jul 20, 2022
fd09977
Merge pull request #2614 from smnscp/fix-content-type-in-fog-copy-opt…
mshibuya Jul 23, 2022
f6391bb
Stop unnecessarily using GitHub-sourced gems
mshibuya Sep 10, 2022
b104d0f
Temporarily lock ssrf_filter to work around #2625
mshibuya Sep 10, 2022
ba50008
Raise DownloadError when no content is returned
BrianHawley Sep 28, 2022
c10e7ef
Support ssrf_filter 1.1
BrianHawley Sep 15, 2022
2ef5888
Update apt before installing packages
BrianHawley Sep 29, 2022
554759c
Update apt before installing packages
BrianHawley Sep 29, 2022
a0c093f
Merge pull request #2629 from BrianHawley/fixes_2625
mshibuya Oct 1, 2022
f7ec874
chore: minor refactor from select first to detect
nachiket87 Oct 2, 2022
3ef4d59
Merge pull request #2637 from nachiket87/improve-slight-performance
mshibuya Oct 2, 2022
83fcd75
Merge pull request #2633 from BrianHawley/fixes_2632
mshibuya Oct 2, 2022
c9bcb86
fix: ruby 2.7 kwarg warning in uploader process
nachiket87 Oct 2, 2022
9d03bcd
Merge pull request #2636 from nachiket87/fix-ruby-kwarg-warning-for-o…
mshibuya Oct 8, 2022
65bf0d9
Workaround for 'undefined method closed?' error caused by ssrf_filter…
mshibuya Nov 6, 2022
0a6ffe1
Update actions/checkout to v3 to supress the Node.js 12 deprecation
mshibuya Nov 6, 2022
6cb797a
Version 3.0.0.beta
mshibuya Nov 19, 2022
dec6d15
Local storage clean_cache! fix for off-topic files
BrianHawley Nov 21, 2022
c29d4dd
Merge pull request #2641 from BrianHawley/fixes_2532
mshibuya Nov 22, 2022
ce45649
Enable to set 'false' via in-class configuring
megane42 Dec 5, 2022
bcc3bb0
Separate a test case by concerns
megane42 Dec 19, 2022
e270d62
Merge pull request #2642 from megane42/enable-to-set-false
mshibuya Dec 19, 2022
9096459
Let SanitizedFile#read accept optional arguments
mshibuya Dec 18, 2022
68ce83a
Add CarrierWave::Storage::Fog::File#to_file
mshibuya Dec 25, 2022
eca7b98
Perform RuboCop check in CI
mshibuya Dec 26, 2022
f1eff6e
Fix column value populated without a file when using filename override
mshibuya Jan 1, 2023
b719fb3
Fix remove_#{column}! doesn't remove the file immediately
mshibuya Jan 2, 2023
19b33b8
Support ActiveRecord#dup
mshibuya Jan 2, 2023
9fcd397
Suppress RuboCop offense
mshibuya Jan 2, 2023
7af2ad2
Support to configure download retry wait time
tricknotes Jan 4, 2023
67b2cda
Merge pull request #2646 from tricknotes/download-retry-wait-time
mshibuya Jan 4, 2023
41de5e3
Run CI with latest Ruby and rails HEAD
tricknotes Jan 5, 2023
5aa2d44
Add CI matrix for latest Ruby and Rails
tricknotes Jan 5, 2023
12cc259
Update Ruby version for rubocop on CI
tricknotes Jan 5, 2023
d9b155c
s/filaname/filename/
ydah Jan 5, 2023
5d6f8bb
s/sybmols/symbols/
ydah Jan 5, 2023
a9b275b
s/iamges/images/
ydah Jan 5, 2023
e45f700
s/integity/integrity/
ydah Jan 5, 2023
5236886
s/enforece/enforce/
ydah Jan 5, 2023
f57ce87
s/Santized/Sanitized/
ydah Jan 5, 2023
56db163
s/exsting/existing/
ydah Jan 5, 2023
39f0b08
s/compartibility/compatibility/
ydah Jan 5, 2023
dcb3908
Added dependabot for GitHub Actions
ydah Jan 5, 2023
fda48ef
Forward to 2.x changelog for older changes
mshibuya Jan 8, 2023
698a293
Merge pull request #2648 from tricknotes/ci-for-ruby-3.2
mshibuya Jan 8, 2023
622644d
Merge pull request #2649 from ydah/fix-typo
mshibuya Jan 8, 2023
67423b5
Merge pull request #2650 from ydah/add-dependabot
mshibuya Jan 8, 2023
6574a8f
Add spec to ensure #recreate_versions! doesn't break when file isn't …
mshibuya Jan 8, 2023
a67bfb6
Fix #recreate_versions! affecting the original file
mshibuya Jan 9, 2023
743ee24
Update RubyDoc link. Closes #2542
mshibuya Jan 9, 2023
1fecddc
Fix to respect condition on processing a derived version
mshibuya Jan 9, 2023
af807ad
Change the year of the license to the first publication date only
ydah Jan 10, 2023
acc66fc
Merge pull request #2651 from ydah/update-license-year
mshibuya Jan 10, 2023
8dace34
Use AWS S3 regional endpoints when using virtual-hosted style
mshibuya Jan 14, 2023
a9de756
Give a stable name to version classes
mshibuya Jan 15, 2023
e84d11e
Fix `#{column}_cache=` fails to be stored when set as a nested attribute
mshibuya Jan 15, 2023
c4dd57e
Fix #clean_cache! to delete uploader root
sawasaki-narumi Jan 17, 2023
e2af599
Fix dup with multiple mounters or not cached
BrianHawley Jan 4, 2023
ba986b7
Merge pull request #2645 from BrianHawley/fixes_1962
mshibuya Jan 20, 2023
8307f93
Support clearing #remote_urls by assigning nil
mshibuya Jan 20, 2023
9013999
Provide validation error details
mshibuya Jan 20, 2023
f5b09b8
Give a stable name to classes created by the mount_uploader block
mshibuya Jan 21, 2023
f34a9bd
Remove unnecessary floodfill in CarrierWave::RMagick#resize_and_pad
mshibuya Jan 21, 2023
d90c399
Fix to raise exception when ImageMagick is not installed
mshibuya Jan 21, 2023
f234e63
Bugfix: fix Kernel#=~ removal in Ruby 3.2
aubinlrx Jan 23, 2023
f8ea354
Restore previous behavior of clearing attachments via attribute assig…
mshibuya Feb 9, 2023
5f00715
Fix #save breaks after #recreate_versions!
mshibuya Feb 16, 2023
172bc21
Handle assignments in an ActiveModel::Dirty-friendly way
mshibuya Feb 26, 2023
4597f39
Merge pull request #2658 from carrierwaveuploader/activemodel-dirty-c…
mshibuya Mar 12, 2023
54f4d27
Allow Rails main build to fail until rspec/rspec-mocks#1530 is fixed
mshibuya Mar 12, 2023
c4bb30b
[BREAKING CHANGE] Use the resulting file extension on changing format…
mshibuya Mar 11, 2023
312c9f7
Use helper method to access fog_provider
joshuamsager Mar 15, 2023
1dc6de5
Merge pull request #2660 from joshuamsager/joshuamsager/cleaner-fog_p…
mshibuya Mar 18, 2023
c290f51
Handle experimental builds better
mshibuya Mar 18, 2023
010b4e4
Merge pull request #2592 from TsubasaYoshida/dimensions-validation
mshibuya Mar 18, 2023
3b1f8b4
Follow-up for #2592
mshibuya Mar 18, 2023
5dab8fd
Merge pull request #2652 from sawasaki-narumi/master
mshibuya Mar 18, 2023
3cb9992
Follow-up for #2652
mshibuya Mar 18, 2023
ec05cbc
Merge pull request #2653 from aubinlrx/bugfix/ruby_32_IntegerClass_Fa…
mshibuya Mar 18, 2023
fd03ddd
Follow-up for #2653
mshibuya Mar 18, 2023
4e7dd40
remove deprecated configuration from README
cou929 Mar 25, 2023
6c4df8c
Merge pull request #2661 from cou929/remove-reprecated-config
mshibuya Mar 26, 2023
a2ca59c
Prioritize Magic-detected content type for spoof-tolerance
mshibuya Mar 29, 2023
6c6e2dc
Do not invoke content type detection on #move_to and #copy_to
mshibuya Mar 31, 2023
436f51e
Merge pull request #2659 from carrierwaveuploader/use-converted-file-…
mshibuya Mar 31, 2023
2f3afaf
Try to preserve the original URI as much as possible
mshibuya Apr 2, 2023
4c22006
Mention that size_range is in bytes
ibrahima Apr 11, 2023
bbe0919
Merge pull request #2662 from ibrahima/patch-1
mshibuya Apr 12, 2023
1531a67
Create versions lazily to reflect subclass configurations properly
mshibuya Apr 9, 2023
aac25c1
Stop relying on ActiveModel::Dirty change tracking for removal of unn…
mshibuya May 1, 2023
07a5632
Add suffix to filename on store when path collides with the existing …
mshibuya May 7, 2023
246eb01
Change CarrierWave::Storage::Fog::File#read to return nil when the fi…
mshibuya Jun 4, 2023
114d593
Version 3.0.0.rc
mshibuya Jun 11, 2023
269c37a
Version 3.0.0 :rocket:
mshibuya Jul 2, 2023
75bf129
Mention `libvips` in CONTRIBUTING.md
y-yagi Jul 6, 2023
875d972
Fix initialization failing when active_support/core_ext is not loaded…
mshibuya Jul 9, 2023
b732acd
Fix #dup causing unintended name deduplication of copied files
mshibuya Jul 9, 2023
3a24616
Merge pull request #2671 from y-yagi/update-contributing-doc
mshibuya Jul 11, 2023
d68a111
Fix filename suffix being removed due to unnecessary deduplication
mshibuya Jul 12, 2023
db95563
Fix a `NoMethodError` when a record is rollbacked
y-yagi Jul 14, 2023
73bacd2
Merge pull request #2674 from y-yagi/fix-NoMethodError-from-remove_added
mshibuya Jul 15, 2023
2df0f53
Fix not respecting the parent's #enable_processing value after readin…
mshibuya Jul 22, 2023
3bdbfda
Version 3.0.1
mshibuya Jul 22, 2023
057b7a5
Fix deduplicated filename not being persisted
mshibuya Jul 29, 2023
d6b522f
Merge pull request #2679 from carrierwaveuploader/fix-deduplicated-fi…
mshibuya Aug 1, 2023
d339c27
Version 3.0.2
mshibuya Aug 1, 2023
847ea59
delete duplicate tests
rajyan Aug 17, 2023
1e63b19
add failing test for https://github.com/carrierwaveuploader/carrierwa…
rajyan Aug 17, 2023
eb03fe1
Fix wrongly removing files on transaction rollback
mshibuya Aug 17, 2023
26b6bbd
Merge pull request #2686 from rajyan/rollback-regression
mshibuya Aug 17, 2023
37f36f7
Fix #dup modifying the original object
mshibuya Aug 19, 2023
3a9e5a0
Merge pull request #2684 from rajyan/refactor-duplicate-tests
mshibuya Aug 19, 2023
f31546a
Version 3.0.3
mshibuya Aug 21, 2023
c6d0aa9
add failing test for https://github.com/carrierwaveuploader/carrierwa…
rajyan Aug 22, 2023
23be183
improve spec
rajyan Aug 23, 2023
c35f486
fix to dup @_mounters cache, because Object#dup wont duplicate @_moun…
rajyan Aug 23, 2023
b1f79da
fix: call #dup raise error while mount_uploader with :mount_on option
marsz Aug 23, 2023
9216dfc
Merge pull request #2691 from marsz/master
mshibuya Aug 27, 2023
e53c9c3
fix to dup mounters cache on mount
rajyan Aug 27, 2023
8815592
Merge pull request #2690 from rajyan/issue-2689-fix
mshibuya Aug 28, 2023
fb74a1d
add skip_ssrf_protection config
rajyan Sep 5, 2023
8763e5f
Bump actions/checkout from 3 to 4
dependabot[bot] Sep 11, 2023
0916696
mention skip_ssrf_protection in README
rajyan Sep 11, 2023
b7a9edc
Improve content type detection for .dotx and .ai
dzhikvas Sep 12, 2023
0f4b300
add failing test cases for https://github.com/carrierwaveuploader/car…
rajyan Sep 12, 2023
9b0dabf
reorder to assign nil after @_mounters dup
rajyan Sep 13, 2023
f4e58cb
add failing test cases for https://github.com/carrierwaveuploader/car…
rajyan Sep 13, 2023
a273057
delete unrelated test
rajyan Sep 13, 2023
8066ebc
write_temporary_identifier only if remove is changed to truthy value
rajyan Sep 13, 2023
54c97f2
Update spec/orm/activerecord_spec.rb
rajyan Sep 16, 2023
fac358c
Merge pull request #2706 from rajyan/dup-file-upload-failure-failing-…
mshibuya Sep 17, 2023
96398d9
Merge pull request #2703 from carrierwaveuploader/dependabot/github_a…
mshibuya Sep 23, 2023
cfaf173
allow remove_image to be cancelled
rajyan Sep 24, 2023
c7262b9
add a failing test case for https://github.com/carrierwaveuploader/ca…
rajyan Sep 24, 2023
39f4da0
Merge pull request #2707 from rajyan/fix-issue-2702
mshibuya Sep 24, 2023
969e3aa
Test against Rails 7.1
mshibuya Oct 8, 2023
0c50a8b
Version 3.0.4
mshibuya Oct 8, 2023
5c8dc98
delete `if original_filename` as explained in https://github.com/carr…
rajyan Oct 30, 2023
a4ccfe7
Merge pull request #2711 from rajyan/original-filename-cleanup
mshibuya Nov 23, 2023
a5c0d3c
Fix ruby-head build
mshibuya Nov 23, 2023
863d425
Fix Content-Type allowlist bypass vulnerability
mshibuya Nov 28, 2023
5316b35
Version 3.0.5
mshibuya Nov 29, 2023
18aacd4
Fix failing to remove files with ActiveRecord 7.1 after_commit order …
mshibuya Dec 3, 2023
0196b21
Update README.md to indicate skip_ssrf_protection should be used only…
mshibuya Dec 3, 2023
717b207
Fix #derived_versions and #active_sibling_versions returning an Array…
mshibuya Dec 3, 2023
c1f500a
Merge pull request #2696 from rajyan/skip-ssrf-protection-config
mshibuya Dec 3, 2023
20c6d75
Merge pull request #2705 from dzhikvas/fix-content-type-detection
mshibuya Dec 3, 2023
5f3170b
Update Callback Documentation
jiikko Jan 4, 2024
d27c987
Merge pull request #2717 from jiikko/patch-1
mshibuya Jan 7, 2024
9ccc2e3
Added support for the "crop" method to the vips processor.
clickworkorange Jan 24, 2024
660dee7
Butterfingers.
clickworkorange Jan 24, 2024
a2c7bf1
Added csv as a gemspec requirement (removed in Ruby 3.4). Removed tra…
clickworkorange Jan 25, 2024
37d6005
Maybe "csv" should only be a development_dependency?
clickworkorange Jan 25, 2024
0a8bde8
I should run RuboCop locally before committing. Repeat 100x times.
clickworkorange Jan 25, 2024
ac24a03
Fix ruby-head build
mshibuya Jan 29, 2024
21e346e
Show warning if #filename is safeguarded as in the pre-3.x style
mshibuya Jan 13, 2024
7b37d56
Add documentation for supporting S3 with ACLs disabled and GCS unifor…
mshibuya Jan 29, 2024
7c07da8
Merge branch 'carrierwaveuploader:master' into master
clickworkorange Feb 2, 2024
b3b7cd3
Removed duplicate "csv" dependency.
clickworkorange Feb 2, 2024
47f1737
Fix assigning a file with the same name not marking the column as cha…
mshibuya Feb 4, 2024
8b33235
Merge pull request #2718 from carrierwaveuploader/warn-if-filename-is…
mshibuya Feb 4, 2024
e83118b
Added support for "crop" method to RMagic and MiniMagic processors.
clickworkorange Feb 5, 2024
b355e37
Fixed `yield` of RMagic `crop` method.
clickworkorange Feb 5, 2024
aff2614
Updated README to include information about Vips and the "crop" proce…
clickworkorange Feb 6, 2024
a507b9f
Update README.md
clickworkorange Feb 12, 2024
ed87991
Merge pull request #2721 from clickworkorange/master
mshibuya Feb 12, 2024
f76a62d
Use Marcel::TYPE_EXTS instead of Marcel::TYPES
schinery Feb 29, 2024
264410f
Fix for rmagick spec
schinery Mar 1, 2024
f06679e
Use Marcel::Magic.new instead of private constant
schinery Mar 1, 2024
fb443a5
Revert bumping Marcel to 1.0.3
schinery Mar 1, 2024
e148cd8
Merge pull request #2728 from schinery/main
mshibuya Mar 2, 2024
25b1c80
Fix Content-Type allowlist bypass vulnerability remained
mshibuya Mar 20, 2024
1fbb4c7
Update changelog
mshibuya Mar 23, 2024
3b88d40
Fix typos
kianmeng Apr 1, 2024
aaeaca3
Merge pull request #2735 from kianmeng/fix-typos
mshibuya Apr 1, 2024
e0957b8
README improvements
Uaitt Apr 12, 2024
287e9a1
Only load fog-rackspace on Rails 6.x due to incompatibility with fog-…
mshibuya Apr 14, 2024
5e8510b
Merge pull request #2738 from Uaitt/documentation-typos
mshibuya Jun 1, 2024
65e5e8e
Pin sqlite3 to 1.x, to fix Rails 7 builds
mshibuya Jun 1, 2024
b25477d
Introduce ActiveSupport Deprecator
mshibuya Jun 1, 2024
05ad168
CI against Ruby 3.3
y-yagi Jun 12, 2024
c531c07
Merge pull request #2744 from y-yagi/ci-against-ruby33
mshibuya Jun 25, 2024
8761240
Fix failing to set app.deprecators in Rails <= 7.0
mshibuya Jul 6, 2024
665e5e3
Change version constant naming pattern
r7kamura Aug 7, 2024
fbe397e
fix URLs
Aug 14, 2024
d1509b3
Merge pull request #2748 from r7kamura/version-const-name
mshibuya Aug 25, 2024
8a074f6
Merge pull request #2750 from yasudatoshiyuki/fix-urls
mshibuya Aug 25, 2024
2e8bfc0
Version 3.1.0.beta
mshibuya Sep 1, 2024
2d1af56
Add CarrierWave::Storage::Fog::File#empty?, for consistency with Sani…
mshibuya Sep 22, 2024
21ca90a
Rename #version_exists? to #version_active?, to reduce confusion
mshibuya Sep 22, 2024
d0c18f7
CI against Rails 7.2
y-yagi Oct 2, 2024
8b7d477
Merge pull request #2755 from y-yagi/ci-against-rails72
mshibuya Oct 14, 2024
ca580f0
Fix typo in README: change 'al three' to 'all three'
k-in0ue Oct 17, 2024
ce272b7
Merge pull request #2756 from kazuyainoue0124/fix_typos_in_readme
mshibuya Oct 19, 2024
bb8c6e1
Clear download errors on reassigning remote urls
mshibuya Oct 14, 2024
a5518d6
Fix ruby-head build
mshibuya Oct 19, 2024
05fa71f
Use RFC2396_REGEXP explicitly
ollym Nov 7, 2024
8485fee
Merge pull request #2760 from ollym/patch-1
mshibuya Nov 9, 2024
61c2732
Custom WebMock matcher no longer needed for ssrf_filter 1.2.0
mshibuya Nov 10, 2024
3c8ad1f
The CarrierWave::Storage::File#public_url method returns the standard
matt-domsch-sp Nov 18, 2024
ae2a277
Move test for GovCloud or FIPS higher
matt-domsch-sp Nov 20, 2024
738a5ce
Add warning for S3TA disabling
matt-domsch-sp Nov 20, 2024
504bf0e
fix typo in warning message
matt-domsch-sp Nov 21, 2024
a60d8d8
Stop using MiniMagick::Image#run_command
mshibuya Nov 23, 2024
c35e37b
remove disabling S3TA
matt-domsch-sp Nov 23, 2024
ccd6603
Add fog_aws_fips config option, tests
matt-domsch-sp Nov 25, 2024
0d5a661
Return nil if both :endpoint given and :fog_aws_fips=true
matt-domsch-sp Nov 28, 2024
054bd3d
Merge pull request #2763 from matt-domsch-sp/govcloud-fips-entrypoint
mshibuya Dec 1, 2024
04bfab3
Follow-up for #2763
mshibuya Dec 1, 2024
fb287f3
Show warning when conditionals are used with :convert
mshibuya Dec 7, 2024
7755e3e
Test against Rails 8.0
mshibuya Dec 7, 2024
db7a7eb
Version 3.1.0.rc
mshibuya Dec 7, 2024
d85c9e6
Version 3.1.0
mshibuya Dec 14, 2024
d4bfa31
Add CarrierWave::Vips comment to uploader template
w-masahiro-ct Dec 30, 2024
ce0aee8
Merge pull request #2769 from w-masahiro-ct/add-vips-comment-to-uploa…
mshibuya Dec 31, 2024
9eace1c
Fix SanitizedFile#read to behave in the same way with IO#read with ar…
mshibuya Dec 31, 2024
f062091
Remove old specs that are no longer relevant
mshibuya Dec 31, 2024
7cda4e4
Fix #dup with custom serialisation
a-nassim Jan 3, 2025
01ebc84
Raise MiniMagick::Error if ImageMagick is missing delegates
danwilliams-fl Jan 7, 2025
f993eb7
Remove use of deprecated mb_chars method
chaadow Jan 8, 2025
3139628
Update sanitized_file.rb
chaadow Jan 8, 2025
97bd98b
Merge pull request #2771 from nassim-platogo/bugfix/use-write-uploade…
mshibuya Jan 11, 2025
b4d43c3
Merge pull request #2772 from futurelearn/dw-am-explicit-errors-for-m…
mshibuya Jan 11, 2025
08a3698
Merge pull request #2773 from chaadow/patch-1
mshibuya Jan 11, 2025
ee24133
Bump cucumber gem
mshibuya Jan 11, 2025
23bfc39
Update build matrix
mshibuya Jan 11, 2025
550e423
Version 3.1.1
mshibuya Jan 12, 2025
9001ab7
Fix specs breaking with MiniMagick 5.x
mshibuya Mar 16, 2025
7b2ce50
Fix failing to remove existing files on updating by `#remove_#{column…
mshibuya Mar 16, 2025
8e5db8c
Version 3.1.2
mshibuya Apr 13, 2025
e76e860
ci: update Ubuntu runner to 24.04 LTS
mshibuya Jun 14, 2025
a51a970
Provide a 'Changelog' link on rubygems.org/gems/carrierwave (#2774)
mark-young-atg Jun 14, 2025
4b797ef
Cope with the change in MiniMagick 5.3
mshibuya Sep 14, 2025
2d14664
Add content_type_allowlist example to uploader template (#2785)
coloradosazulyanaranjados Sep 14, 2025
b53a725
Bump actions/checkout from 4 to 5 (#2790)
dependabot[bot] Sep 14, 2025
a015f02
Update build matrix
mshibuya Sep 14, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
version: 2
updates:
- package-ecosystem: github-actions
directory: "/"
schedule:
interval: "weekly"
78 changes: 78 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
name: Test

on: [push, pull_request]

jobs:
test:
name: RSpec and Cucumber
strategy:
fail-fast: false
matrix:
ruby: [ '3.2', '3.3', '3.4' ]
gemfile: [ gemfiles/rails-8-0.gemfile ]
experimental: [ false ]
include:
- ruby: '2.5'
gemfile: gemfiles/rails-6-0.gemfile
experimental: false
- ruby: '2.6'
gemfile: gemfiles/rails-6-1.gemfile
experimental: false
- ruby: '2.7'
gemfile: gemfiles/rails-7-0.gemfile
experimental: false
- ruby: '3.0'
gemfile: gemfiles/rails-7-1.gemfile
experimental: false
- ruby: '3.1'
gemfile: gemfiles/rails-7-2.gemfile
experimental: false
- ruby: '3.4'
gemfile: gemfiles/rails-main.gemfile
experimental: true
- ruby: ruby-head
gemfile: gemfiles/rails-8-0.gemfile
experimental: false
- ruby: jruby
gemfile: gemfiles/rails-7-2.gemfile
experimental: false
- ruby: jruby-head
gemfile: gemfiles/rails-7-2.gemfile
experimental: true
runs-on: ubuntu-24.04
continue-on-error: ${{ matrix.experimental }}
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
JRUBY_OPTS: --debug
steps:
- uses: actions/checkout@v5
- name: Update package list
run: sudo apt update
- name: Install ImageMagick and setup policy
run: sudo apt-get install imagemagick && sudo sh -c 'echo '\''<policymap><policy domain="coder" rights="read|write" pattern="PDF" /></policymap>'\'' > /etc/ImageMagick-6/policy.xml'
- name: Install ghostscript to process PDF
run: sudo apt-get -y install ghostscript
- name: Install libvips-dev for Carrierwave::Vips
run: sudo apt-get install libvips-dev
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Run RSpec
run: bundle exec rake spec
- name: Run Cucumber
run: bundle exec rake features

rubocop:
name: RuboCop
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v5
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.4"
bundler-cache: true
- name: Run check
run: bundle exec rubocop
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,12 @@ more/activerecord/spec/db
more/activerecord/spec/public
more/datamapper/spec/public
*.project
spec/fixtures/*_copy.png
spec/test.log
spec/tmp
*.swp
.rvmrc
.idea
.bundle
Gemfile.lock
Gemfile.lock
gemfiles/*.lock
272 changes: 272 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,272 @@
AllCops:
NewCops: disable
SuggestExtensions: false
TargetRubyVersion: 2.5

Bundler/OrderedGems:
Exclude:
- 'Gemfile'
- 'gemfiles/*'

Gemspec/OrderedDependencies:
Exclude:
- 'carrierwave.gemspec'

Layout/AccessModifierIndentation:
EnforcedStyle: outdent

Layout/DotPosition:
Enabled: false

Layout/EmptyLineAfterGuardClause:
Enabled: false

Layout/EmptyLinesAroundBlockBody:
Enabled: false

Layout/EmptyLinesAroundClassBody:
Enabled: false

Layout/EmptyLinesAroundModuleBody:
Enabled: false

Layout/FirstHashElementIndentation:
EnforcedStyle: consistent

Layout/HashAlignment:
Enabled: false

Layout/MultilineMethodCallIndentation:
EnforcedStyle: indented

Layout/SpaceAroundEqualsInParameterDefault:
Enabled: false

Layout/SpaceAroundOperators:
Enabled: false

Layout/SpaceBeforeBlockBraces:
Enabled: false

Layout/SpaceInsideBlockBraces:
Enabled: false

Layout/SpaceInsideHashLiteralBraces:
Enabled: false

Layout/SpaceInsideParens:
Enabled: false

Lint/AmbiguousBlockAssociation:
Enabled: false

Lint/AmbiguousRegexpLiteral:
Enabled: false

Lint/MissingSuper:
Exclude:
- 'spec/processing/rmagick_spec.rb'

Lint/UnusedBlockArgument:
Enabled: false

Lint/UnusedMethodArgument:
Enabled: false

Lint/UselessMethodDefinition:
Exclude:
- 'spec/**/*'

Metrics/AbcSize:
Enabled: false

Metrics/BlockLength:
Enabled: false

Metrics/BlockNesting:
Max: 5

Metrics/ClassLength:
Enabled: false

Metrics/CyclomaticComplexity:
Max: 18

Metrics/MethodLength:
Enabled: false

Metrics/ModuleLength:
Enabled: false

Metrics/ParameterLists:
Enabled: false

Metrics/PerceivedComplexity:
Max: 31

Naming/AccessorMethodName:
Enabled: false

Naming/FileName:
Exclude:
- 'gemfiles/*'

Naming/MethodParameterName:
Enabled: false

Naming/PredicatePrefix:
Exclude:
- 'spec/**/*'
- 'lib/carrierwave/sanitized_file.rb'
- 'lib/carrierwave/test/matchers.rb'

Naming/VariableNumber:
Enabled: false

Security/Eval:
Exclude:
- 'lib/carrierwave/uploader/configuration.rb'
- 'spec/storage/fog_helper.rb'

Security/Open:
Exclude:
- 'spec/storage/fog_helper.rb'

Style/Alias:
EnforcedStyle: prefer_alias_method

Style/BlockDelimiters:
Enabled: false

Style/ClassAndModuleChildren:
Exclude:
- 'spec/tmp/app/uploaders/my_module/avatar_uploader.rb'

Style/ClassVars:
Exclude:
- 'lib/carrierwave/uploader/cache.rb'

Style/CommentedKeyword:
Enabled: false

Style/ConditionalAssignment:
Enabled: false

Style/Documentation:
Enabled: false

Style/EmptyMethod:
Enabled: false

Style/EvalWithLocation:
Exclude:
- 'spec/storage/fog_helper.rb'

Style/FormatString:
Enabled: false

Style/FormatStringToken:
EnforcedStyle: template

Style/FrozenStringLiteralComment:
Enabled: false

Style/GuardClause:
Enabled: false

Style/HashSyntax:
Enabled: false

Style/IfUnlessModifier:
Enabled: false

Style/Lambda:
Enabled: false

Style/MultilineBlockChain:
Enabled: false

Style/NegatedIf:
Enabled: false

Style/Next:
Enabled: false

Style/NumericLiterals:
MinDigits: 11

Style/OptionalBooleanParameter:
Enabled: false

Style/ParallelAssignment:
Enabled: false

Style/PercentLiteralDelimiters:
Enabled: false

Style/PerlBackrefs:
Enabled: false

Style/PreferredHashMethods:
Enabled: false

Style/Proc:
Enabled: false

Style/RedundantRegexpCharacterClass:
Enabled: false

Style/RedundantRegexpEscape:
Enabled: false

Style/RedundantSelf:
Enabled: false

Style/RegexpLiteral:
Enabled: false

Style/RescueModifier:
Enabled: false

Style/SafeNavigation:
Enabled: false

Style/SingleLineMethods:
Enabled: false

Style/SlicingWithRange:
Enabled: false

Style/SpecialGlobalVars:
EnforcedStyle: use_perl_names

Style/StringConcatenation:
Enabled: false

Style/StringLiterals:
Enabled: false

Style/SymbolArray:
EnforcedStyle: brackets

Style/SymbolProc:
Enabled: false

Style/TernaryParentheses:
Enabled: false

Style/TrailingCommaInHashLiteral:
Enabled: false

Style/TrivialAccessors:
Enabled: false

Style/WordArray:
EnforcedStyle: percent
MinSize: 8

Style/ZeroLengthPredicate:
Enabled: false

Layout/LineLength:
Max: 256
Loading