Skip to content

fix the frames of cua and fea#227

Merged
lynn merged 2 commits intotoaq:masterfrom
mi2ebi:master
Apr 11, 2026
Merged

fix the frames of cua and fea#227
lynn merged 2 commits intotoaq:masterfrom
mi2ebi:master

Conversation

@mi2ebi
Copy link
Copy Markdown
Contributor

@mi2ebi mi2ebi commented Apr 10, 2026

from c ci 1i to c c 1i. i don't personally like either of their definitions but we can address that later or never

@mi2ebi
Copy link
Copy Markdown
Contributor Author

mi2ebi commented Apr 10, 2026

i've also fixed buja (which had an e slot), and chia and dui and ko (which had two non-c slots). new-ko (c c c 1x), koe (c c c 2ij), and teq (c c c 1k) aren't changed beyond that since their definitions still have 4 slots and those frames are all valid if we accept that (though again we could fix the definitions later)

@mi2ebi
Copy link
Copy Markdown
Contributor Author

mi2ebi commented Apr 10, 2026

(so now those are the only three entries where the frames don't match the [whitespace-insensitive] regex

^
(0
|1x?
|2(xx)?
|c(0
  |1[ix]?
  |2([ix]{2})?
  |c(0
    |1[ijx]?
    |2([ijx]{2})?
    |c
    )?
  )?
)?
$

)

Copy link
Copy Markdown
Contributor

@dembim dembim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks uncontroversial to me.

@lynn lynn merged commit 98e1370 into toaq:master Apr 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants