SMTC initialization and identity tweaks#2
Open
badmannersteam wants to merge 1 commit intotoasterofbread:mainfrom
Open
SMTC initialization and identity tweaks#2badmannersteam wants to merge 1 commit intotoasterofbread:mainfrom
badmannersteam wants to merge 1 commit intotoasterofbread:mainfrom
Conversation
badmannersteam
force-pushed
the
dev
branch
2 times, most recently
from
57d321a to
6a4e32c
Compare
- Added identity setup to SMTC - setting AUMID to current process and SMTC DisplayUpdater - Removed unused MediaSessionLinux class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added condition to call
winrt::init_apartment()or not on init step of SMTC.Looks like calling this is not required in every case, because it may be already done in AWT code.
This should also fix the Unable to click any link on Windows spmp#401.
The root issue is https://bugs.openjdk.org/browse/JDK-8270269.
Added identity setup to SMTC - setting AUMID to current process and SMTC
DisplayUpdater.This is required for correct app title and icon in windows action center.
To make this fully operational you also required to create a link in start menu programs section with the same AUMID, that can be done by some MSI installers/calls to win api/special software.
More info here.
Removed unused
MediaSessionLinuxclass and updated JNA dependency