Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
98 commits
Select commit Hold shift + click to select a range
423356e
inclass work. Created new tests
MunkyCode Jan 22, 2020
9313e80
BankAccount is email valid given a definition
Jan 23, 2020
4a00338
Gave withdraw tests as well as described how to fix withdraw tests to…
Jan 23, 2020
615fb77
Comments about partitions and boundary values added to withraw and va…
Jan 23, 2020
117b124
isEmailValid updated so all tests pass
Jan 23, 2020
e1f225d
switching to desktop
MunkyCode Jan 24, 2020
9b3cbcd
updated tests
MunkyCode Jan 25, 2020
740efc5
Withdraw and isEmailValid work
Jan 26, 2020
712230e
Tests for isAmountValid
MunkyCode Jan 28, 2020
60dc2ef
end of class
Jan 28, 2020
c5da040
isAmountValid implamentation added
MunkyCode Jan 29, 2020
2726723
tests for illegal aurguments with amounts for constructor and withdraw
MunkyCode Jan 29, 2020
9fe9214
added implementation for illegal arguments with constructor and withd…
MunkyCode Jan 29, 2020
0bdafbe
added tests for inseficient funds and decimal withdraws
MunkyCode Jan 29, 2020
f5c4b31
added implementation of inseficeint funds error being throw in withdraw
MunkyCode Jan 29, 2020
f9c27f5
added a few more tests for isEmailValid
MunkyCode Jan 29, 2020
ab3adb1
Updated isEmailValid function to include more cases
MunkyCode Jan 29, 2020
4be5d39
added tests for deposit
MunkyCode Jan 29, 2020
aca3775
added tests for transfer
MunkyCode Jan 29, 2020
4085359
changes to tests to be transfer from one object to another rather tha…
MunkyCode Jan 29, 2020
b9b9d71
added tests for transfer to include invalid funds exception
MunkyCode Jan 29, 2020
53d20c1
added implemntation of deposit and transfer
MunkyCode Jan 29, 2020
77e7c1e
files from class
MunkyCode Feb 3, 2020
4fec654
moving files to the right location
MunkyCode Feb 3, 2020
ecaa624
fixed spelling error
MunkyCode Feb 3, 2020
71c80e7
added accounts
MunkyCode Feb 5, 2020
d6324cd
withdraw tests
MunkyCode Feb 5, 2020
be8fd6e
finished implementation of withdraw
MunkyCode Feb 5, 2020
fce2b20
withdrawTests
Feb 5, 2020
97351c2
withdraw test and implementation
mdiallo707 Feb 6, 2020
4275e50
more updates
Feb 10, 2020
cbd4566
Merge branch 'master' of https://github.com/MunkyCode/SoftwareEnginee…
mdiallo707 Feb 10, 2020
54f198c
updated changes
Feb 10, 2020
32aeaf7
Merge pull request #1 from MunkyCode/MDiallo1
MunkyCode Feb 10, 2020
676b801
Added customer class
MunkyCode Feb 10, 2020
db6386c
added 2 mroe methods to customer
MunkyCode Feb 10, 2020
0d4e0d3
added customer collection and methods to match the given apis
MunkyCode Feb 10, 2020
7f0156f
added ATM
MunkyCode Feb 10, 2020
df10693
added bankeTeller
MunkyCode Feb 10, 2020
9626075
created test files for all classes
MunkyCode Feb 10, 2020
ea03542
updated ATM and BankTeller
MunkyCode Feb 10, 2020
e95021e
Merge branch 'master' into withdrawTest
MunkyCode Feb 10, 2020
3a638a5
Merge pull request #3 from MunkyCode/withdrawTest
MunkyCode Feb 10, 2020
7886a53
Merge pull request #2 from MunkyCode/classSetup
Ishasharmax Feb 11, 2020
61dd4ad
changes
Feb 11, 2020
b0185b2
missing files fixed
MunkyCode Feb 11, 2020
f90c8c4
chnages
Feb 11, 2020
09c4e8f
tests for create account in customer
MunkyCode Feb 11, 2020
fb4716f
implementation for createAccount
MunkyCode Feb 11, 2020
d144d7a
fixed merge errors
MunkyCode Feb 11, 2020
876d384
fixed error in misc.xml
MunkyCode Feb 11, 2020
a4edff7
Merge branch 'master' into createAccount
MunkyCode Feb 11, 2020
82d2053
working on tests problems with xml files
MunkyCode Feb 11, 2020
93ddc09
Merge pull request #4 from MunkyCode/createAccount
mari707 Feb 11, 2020
10c54b4
working add customer
MunkyCode Feb 11, 2020
5eb0368
added tests for add account in CustomerCollection
MunkyCode Feb 11, 2020
cc6b266
Merge branches 'master' and 'createCustomer' of https://github.com/Mu…
MunkyCode Feb 11, 2020
4cbc23d
message
MunkyCode Feb 11, 2020
3dd2cef
added get balance tests
MunkyCode Feb 11, 2020
bd0d133
implementation of getblance and working implementation fo create account
MunkyCode Feb 11, 2020
9eba5b7
added more balance tests
MunkyCode Feb 11, 2020
cda0aac
added tests for closing customer
MunkyCode Feb 11, 2020
0b7e552
implementation of close Customer
MunkyCode Feb 11, 2020
d73f4f6
added creatAcount tests in bankTeller
MunkyCode Feb 11, 2020
623688d
added implemntation for creatAccount in BankTeller
MunkyCode Feb 11, 2020
e7dc477
added tests for closeAccount in bankTeller
MunkyCode Feb 11, 2020
a0d31e0
added implementation to closeAccount in bankTeller
MunkyCode Feb 11, 2020
d41da17
Merge pull request #5 from MunkyCode/createCustomer
mari707 Feb 11, 2020
5ad9738
Update README.md
MunkyCode Feb 11, 2020
479eb64
ATM and CheckingAccount deposit and checkBalance implementation and t…
mdiallo707 Feb 11, 2020
34118d7
Merge branch 'master' of https://github.com/MunkyCode/SoftwareEnginee…
mdiallo707 Feb 11, 2020
94007b8
Update README.md
Ishasharmax Feb 11, 2020
56cb5a7
Update README.md
Ishasharmax Feb 11, 2020
aaec46e
Update README.md
MunkyCode Feb 11, 2020
7a9f8e9
Merge branch 'master' of https://github.com/MunkyCode/SoftwareEnginee…
mdiallo707 Feb 11, 2020
d2c798c
deposit and checkbalance
mdiallo707 Feb 11, 2020
9f5a450
fixing deposit for customerCollection
mdiallo707 Feb 11, 2020
2dfb301
withdraw tests
Feb 11, 2020
22999b4
withdraw changes 1
Feb 11, 2020
54acf7b
Merge pull request #7 from MunkyCode/withdrawCode
MunkyCode Feb 11, 2020
fbab54d
few last updates
MunkyCode Feb 12, 2020
3833b5a
Update ReadMe
mari707 Feb 12, 2020
2f0bd71
Update ReadMe
mari707 Feb 12, 2020
51031a8
Added deposit sequence diagram
mari707 Feb 12, 2020
e59c517
Update README.md
Ishasharmax Feb 12, 2020
a778e91
Update README.md
Ishasharmax Feb 12, 2020
d2f741f
Update README.md
MunkyCode Feb 12, 2020
0eb9368
Update README.md
MunkyCode Feb 12, 2020
48178c6
change from array list to hashmap
MunkyCode Feb 12, 2020
86e017d
Merge pull request #8 from MunkyCode/CustomerCollectionMap
mari707 Feb 14, 2020
5b3fe6e
changed all exception to be sepcific
MunkyCode Feb 14, 2020
0bb514c
changed all exception to be sepcific
MunkyCode Feb 14, 2020
09c819e
tests for addAccount Split
MunkyCode Feb 14, 2020
aa99112
implementation of createAccoutSplit
MunkyCode Feb 14, 2020
7adbccc
Update README.md
MunkyCode Feb 14, 2020
5e1096e
Merge pull request #9 from MunkyCode/createAccountSplit
mari707 Feb 14, 2020
79683ff
transfer code tests & Implementation
Feb 14, 2020
5b68158
Merge branch 'master' into TransferCode
MunkyCode Feb 14, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
192 changes: 97 additions & 95 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,96 +1,98 @@
# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio and WebStorm
# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839

# User-specific stuff
.idea/**/workspace.xml
.idea/**/tasks.xml
.idea/**/usage.statistics.xml
.idea/**/dictionaries
.idea/**/shelf

# Generated files
.idea/**/contentModel.xml

# Sensitive or high-churn files
.idea/**/dataSources/
.idea/**/dataSources.ids
.idea/**/dataSources.local.xml
.idea/**/sqlDataSources.xml
.idea/**/dynamic.xml
.idea/**/uiDesigner.xml
.idea/**/dbnavigator.xml

# Gradle
.idea/**/gradle.xml
.idea/**/libraries

# Gradle and Maven with auto-import
# When using Gradle or Maven with auto-import, you should exclude module files,
# since they will be recreated, and may cause churn. Uncomment if using
# auto-import.
# .idea/modules.xml
# .idea/*.iml
# .idea/modules

# CMake
cmake-build-*/

# Mongo Explorer plugin
.idea/**/mongoSettings.xml

# File-based project format
*.iws

# IntelliJ
out/

# mpeltonen/sbt-idea plugin
.idea_modules/

# JIRA plugin
atlassian-ide-plugin.xml

# Cursive Clojure plugin
.idea/replstate.xml

# Crashlytics plugin (for Android Studio and IntelliJ)
com_crashlytics_export_strings.xml
crashlytics.properties
crashlytics-build.properties
fabric.properties

# Editor-based Rest Client
.idea/httpRequests

# Android studio 3.1+ serialized cache file
.idea/caches/build_file_checksums.ser

##### mac specific

# General
.DS_Store
.AppleDouble
.LSOverride

# Icon must end with two \r
Icon


# Thumbnails
._*

# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent

# Directories potentially created on remote AFP share
.AppleDB
.AppleDesktop
Network Trash Folder
Temporary Items
target/

# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio and WebStorm
# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839

# User-specific stuff
.idea/**/workspace.xml
.idea/**/tasks.xml
.idea/**/usage.statistics.xml
.idea/**/dictionaries
.idea/**/shelf

# Generated files
.idea/**/contentModel.xml

# Sensitive or high-churn files
.idea/**/dataSources/
.idea/**/dataSources.ids
.idea/**/dataSources.local.xml
.idea/**/sqlDataSources.xml
.idea/**/dynamic.xml
.idea/**/uiDesigner.xml
.idea/**/dbnavigator.xml

# Gradle
.idea/**/gradle.xml
.idea/**/libraries

# Gradle and Maven with auto-import
# When using Gradle or Maven with auto-import, you should exclude module files,
# since they will be recreated, and may cause churn. Uncomment if using
# auto-import.
# .idea/modules.xml
# .idea/*.iml
# .idea/modules

# CMake
cmake-build-*/

# Mongo Explorer plugin
.idea/**/mongoSettings.xml

# File-based project format
*.iws

# IntelliJ
out/

# mpeltonen/sbt-idea plugin
.idea_modules/

# JIRA plugin
atlassian-ide-plugin.xml

# Cursive Clojure plugin
.idea/replstate.xml

# Crashlytics plugin (for Android Studio and IntelliJ)
com_crashlytics_export_strings.xml
crashlytics.properties
crashlytics-build.properties
fabric.properties

# Editor-based Rest Client
.idea/httpRequests

# Android studio 3.1+ serialized cache file
.idea/caches/build_file_checksums.ser

##### mac specific

# General
.DS_Store
.AppleDouble
.LSOverride

# Icon must end with two \r
Icon


# Thumbnails
._*

# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent

# Directories potentially created on remote AFP share
.AppleDB
.AppleDesktop
Network Trash Folder
Temporary Items
.apdisk
2 changes: 2 additions & 0 deletions .idea/SoftwareEngineeringPractice.iml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions .idea/compiler.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 6 additions & 5 deletions .idea/encodings.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion .idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions .idea/modules.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions .idea/sbt.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/vcs.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 25 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,25 @@
# SoftwareEngineeringPractice
## grading

To Do | correct
---|---
at least 8 commits|
isEmailValid|
withdraw|
isamountValid|
constructor & withdraw fix|
Class Diagram: https://drive.google.com/file/d/19JT3qFx5QZFDDfXToH9PeJ05eA53T-fP/view?usp=sharing

Use Case Diagram: https://drive.google.com/file/d/12X02lLneMNfAI1tqyTuFt6AKf051U_tC/view?usp=sharing

CreateAccount Sequence Diagram : https://drive.google.com/file/d/17_fjRoPPmLSFtNEhx62D5JeDLVHGVAaf/view?usp=sharing

Withdraw Sequence diagram BankTeller: https://drive.google.com/file/d/1V51DPsffUscqPMyOBybJN9zhZhDqYtIu/view?usp=sharing

Withdraw Sequence diagram ATM: https://drive.google.com/file/d/1A6ZFq9g-vcnZ75FzZpjcJTqST8WIMkaQ/view?usp=sharing

Deposit Sequence Diagra BankTeller:https://drive.google.com/file/d/1yJNCy1H_MU2AL990FQnjaZPBFHO4EZJ_/view?usp=sharing

Deposit Sequence Diagram ATM: https://drive.google.com/file/d/1MtKO5KAOeuZTXJ0wA9uj9zg5O3bRGwEa/view?usp=sharing

Ideas for Improvement:

-Use maybe a map for the customer collection.

-Throw particular exception.

-Take createAccount and turn it into createCustomer and addAccountToCustomer

-Admin freeze/Unfreeze

-Transfer
26 changes: 25 additions & 1 deletion SoftwareEngineeringPractice.iml
Original file line number Diff line number Diff line change
@@ -1,2 +1,26 @@
<?xml version="1.0" encoding="UTF-8"?>
<module type="JAVA_MODULE" version="4" />
<module org.jetbrains.idea.maven.project.MavenProjectsManager.isMavenModule="true" type="JAVA_MODULE" version="4">
<component name="NewModuleRootManager" LANGUAGE_LEVEL="JDK_1_8">
<output url="file://$MODULE_DIR$/target/classes" />
<output-test url="file://$MODULE_DIR$/target/test-classes" />
<content url="file://$MODULE_DIR$">
<sourceFolder url="file://$MODULE_DIR$/src/main/java" isTestSource="false" />
<sourceFolder url="file://$MODULE_DIR$/src/test/java" isTestSource="true" />
<excludeFolder url="file://$MODULE_DIR$/target" />
</content>
<orderEntry type="inheritedJdk" />
<orderEntry type="sourceFolder" forTests="false" />
<orderEntry type="library" scope="TEST" name="Maven: org.junit.jupiter:junit-jupiter-engine:5.0.0" level="project" />
<orderEntry type="library" scope="TEST" name="Maven: org.apiguardian:apiguardian-api:1.0.0" level="project" />
<orderEntry type="library" scope="TEST" name="Maven: org.junit.platform:junit-platform-engine:1.0.0" level="project" />
<orderEntry type="library" scope="TEST" name="Maven: org.junit.platform:junit-platform-commons:1.0.0" level="project" />
<orderEntry type="library" scope="TEST" name="Maven: org.opentest4j:opentest4j:1.0.0" level="project" />
<orderEntry type="library" scope="TEST" name="Maven: org.junit.jupiter:junit-jupiter-api:5.0.0" level="project" />
<orderEntry type="library" scope="TEST" name="Maven: junit:junit:4.12" level="project" />
<orderEntry type="library" scope="TEST" name="Maven: org.hamcrest:hamcrest-core:1.3" level="project" />
<orderEntry type="library" scope="TEST" name="Maven: org.junit.platform:junit-platform-runner:1.0.0" level="project" />
<orderEntry type="library" scope="TEST" name="Maven: org.junit.platform:junit-platform-launcher:1.0.0" level="project" />
<orderEntry type="library" scope="TEST" name="Maven: org.junit.platform:junit-platform-suite-api:1.0.0" level="project" />
<orderEntry type="library" scope="TEST" name="Maven: org.junit.vintage:junit-vintage-engine:4.12.0" level="project" />
</component>
</module>
Loading