esp32/uart: sanitize UART state before ISR allocation#3000
Open
addshore wants to merge 1 commit intotoitlang:masterfrom
Open
esp32/uart: sanitize UART state before ISR allocation#3000addshore wants to merge 1 commit intotoitlang:masterfrom
addshore wants to merge 1 commit intotoitlang:masterfrom
Conversation
Disable UART interrupts, reset FIFOs, and clear pending interrupt status before ISR setup in uart.create to avoid stale-state interrupt storms. Also clear RX FIFO after post-enable settling delay and minimize run() lambda capture to avoid primitive-context allocation issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable UART interrupts, reset FIFOs, and clear pending interrupt status before ISR setup in uart.create to avoid stale-state interrupt storms. Also clear RX FIFO after post-enable settling delay and minimize run() lambda capture to avoid primitive-context allocation issues.
This came up while looking for an actual fix that ended up being #2999
So i'm on the fence around if this would actually be a good idea / needed?