Depend on serde_core instead of serde#797
Conversation
Darksonn
left a comment
Darksonn
left a comment
There was a problem hiding this comment.
Hm. The serde_core package must be new. This is the first time I heard about it.
DaniPopes
force-pushed
the
serde_core
branch
from
579784e to
dcd6fe7
Compare
|
CI |
|
Maybe the old version resolver wasn't as smart as the new one. Does it work locally if you let a more modern version (but not too modern that it uses the newer Cargo.lock format) generate the lockfile? |
DaniPopes
force-pushed
the
serde_core
branch
from
dcd6fe7 to
16a496a
Compare
|
I doubt it. Not really sure what we can do about it rather than raise the msrv. |
|
I've tried generating the lockfile with Rust v1.63 and then running Rust v1.57 to see it would fix the issue, and it does, but then a similar second error comes out. I've tested all versions between v1.57 and 1.63, and v1.60 is the first one that works. Other than the Yocto Kirkstone 1 people, I don't expect anyone else to possibly complain for the MSRV bump. Footnotes
|
Cargo.toml
Outdated
| # serde v1.0.220 is the first version that released with `serde_core`. | ||
| # This is required to avoid conflict with other `serde` users which may require an older version. | ||
| [target.'cfg(any())'.dependencies] | ||
| serde = { version = "1.0.220", default-features = false } |
There was a problem hiding this comment.
Given that serde_core has been out for 2 months we may be able to do without this section and keep the MSRV of v1.57
There was a problem hiding this comment.
Sure, I think it should be fine. If errors come up later it can be reconsidered
DaniPopes
force-pushed
the
serde_core
branch
from
16a496a to
becaf4b
Compare
|
Old cargo was very stupid. Should we just give up and bump MSRV 😅? It doesn't seem like a big deal to me. |
This crate does not make use of serde derive macros, thus it can depend on `serde_core` instead of `serde` to speed up users' compile times. See the documentation of [`serde_core`](https://docs.rs/serde_core) for more details.
DaniPopes
force-pushed
the
serde_core
branch
from
becaf4b to
eb2075b
Compare
Unblocks tokio-rs#797. Also removes clippy.toml since clippy MSRV is inferred from manifest rust-version.
3 participants
This crate does not make use of serde derive macros, thus it can depend on
serde_coreinstead ofserdeto speed up users' compile times.See the documentation of
serde_corefor more details.Note that this adds a hiddenserde_corefeature, since we cannot use thedep:syntax when declaring theserdefeature due to this crate's MSRV being lower than the required 1.60.