lib: improve performance of Mutable_Hash_Map when many succeeding hashes have conflicts#5954
Merged
simonvonhackewitz merged 4 commits intotokiwa-software:mainfrom Apr 16, 2026
Conversation
simonvonhackewitz
added
modules
simonvonhackewitz
changed the title
Mutable_Hash_Map when many succeeding hashes have conflicts
Member
|
@simonvonhackewitz Did you do some basic benchmarking to validate this? |
Collaborator
Author
I've used the example from #5885 and the performance for that specific scenario of insertions to succeeding cells after they have been filled by previous insertions does improve. Inserting n elements is no longer in O(n²). However, it does not improve performance for collisions in a single cell. |
michaellilltokiwa
added
performance issue
simonvonhackewitz
force-pushed
the
mutable_hash_map_bad_hash_optimization
branch
from
202fe5a to
b9da9f6
Compare
simonvonhackewitz
force-pushed
the
mutable_hash_map_bad_hash_optimization
branch
from
b9da9f6 to
e5c442e
Compare
when many succeeding hashes have conflicts
simonvonhackewitz
force-pushed
the
mutable_hash_map_bad_hash_optimization
branch
from
e5c442e to
6495bc1
Compare
Member
michaellilltokiwa
left a comment
michaellilltokiwa
left a comment
There was a problem hiding this comment.
It would be good to add a benchmark in /benchmarks covering the most important cases. But does not have to be done in this PR, I would be fine with an enhancement issue.
michaellilltokiwa
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires #5903 to be fixed