fzextract: started work to extract structs#6128
Merged
michaellilltokiwa merged 5 commits intotokiwa-software:mainfrom Feb 26, 2026
Merged
Conversation
Collaborator
|
What does "started work" mean here? How complete is this? What is missing? I'll happily accept this only with partial implementation, but we should know what is done and what needs more work. |
Member
Author
|
I'd say it is 20% complete but already usable on simple header files. I added NYI of the missing things, among them:
|
Collaborator
|
And what is working so far? Your original comment on the pull request is just the code of a generated file. That doesn't really help me in knowing what we can do with this. |
maxteufel
approved these changes
Feb 26, 2026
Collaborator
maxteufel
left a comment
There was a problem hiding this comment.
This lacks a clear specification of what is supposed to happen, which makes this hard to review. Accepting anyway so we can merge, test, and refine this.
Member
Author
|
@maxteufel Yes this all very experimental still... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
example output: