This repository was archived by the owner on Apr 4, 2022. It is now read-only.
Update to support node 8, 10, 12, and 14#21
Open
amaranth wants to merge 1 commit intotokuhirom:masterfrom
Open
Update to support node 8, 10, 12, and 14#21amaranth wants to merge 1 commit intotokuhirom:masterfrom
amaranth wants to merge 1 commit intotokuhirom:masterfrom
Conversation
Author
|
Oh, I see I'm a little too late, the other PR has already been merged. I'll make a new PR with some needed changes to that instead. |
Contributor
|
@amaranth you could have pinged me on discord and I could have added them in :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #20 that aims to do just enough to support newer Node versions. With these changes
npm installandnpm testpass on node 8-14 with no warnings. One test had to be disabled as it was failing on node 8 even before making any changes. Further investigation is needed to determine if that's due to changes in the environment, a previous commit, or if it ever worked.This essentially involved building master, fixing all the warnings from clang (mostly by replacing V8 calls with NAN calls), upgrading node, and repeating until we got to the latest node.