Add support for metric's dimensions + other#7
Open
jringuette wants to merge 7 commits intotomaszkiewicz:masterfrom
Open
Add support for metric's dimensions + other#7jringuette wants to merge 7 commits intotomaszkiewicz:masterfrom
jringuette wants to merge 7 commits intotomaszkiewicz:masterfrom
Conversation
Author
|
Hi @tomaszkiewicz, did you have some time to look at this PR? Anything i can do to help that get merged? |
Upgrade libs
Fix metrics endpoint registration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, here is a PR to add some features. The CHANGELOG.md file pretty much explains what I did change.
Note that I'm not a go developer, so this might not be idiomatic go. Feel free to improve if there are better or more idiomatic ways to write this.
I'm using this webhook at Ticketmaster to push multiple kind of prometheus alerts to Cloudwatch. So my requirements were a little bit different than what this hook was originally intended for. Let me know if you have any questions or comments.