Allow to use more than one primary key within definition files#11
Open
DennisWG wants to merge 2 commits intotomrus88:masterfrom
DennisWG:multiple_indexes
Open
Allow to use more than one primary key within definition files#11DennisWG wants to merge 2 commits intotomrus88:masterfrom DennisWG:multiple_indexes
DennisWG wants to merge 2 commits intotomrus88:masterfrom
DennisWG:multiple_indexes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, this program has issues with files that use more than one primary key which means that, to my knowledge, it is impossible to open them. For example look at
ItemSubClass.dbc(version 2.4.3 build 8606). Both, the first and second column, are used as indices.This pull request aims to fix that by allowing the use of multiple primary keys.
I was only able to test this on a few dbc files from version 2.4.3 (build 8606) and version 1.12.1 (build 5875). However, since this is a fairly minimal change I'd not expect this to break anything.