Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there - amazing and concise work here!
I went ahead and changed your action target to be "touch drag inside" from "value changed"
"Value changed" only calls back on "touchEventsDidEnd", while "touch drag inside" is continuously updated.
I also went ahead and added a double ("currVal") to check against, so that the app only attempts to update the blur after a non-trivial slider move (1/range).
This can easily be changed, but is good to note so that people don't slam their processors with updates they won't see (cause you'll already be trying to blur to a new radius).
Finally, I added the readout for "value" to the slider, so you can read it now. (Before it just printed "Slider Value:")
Hope you dig, and thank you for your super helpful contribution to the open source iOS community.