bugfix: same data conversion in transmit as in read method#1
Open
botmonster wants to merge 1 commit intotomstokes:masterfrom
Open
bugfix: same data conversion in transmit as in read method#1botmonster wants to merge 1 commit intotomstokes:masterfrom
botmonster wants to merge 1 commit intotomstokes:masterfrom
Conversation
Owner
|
Hey botmonster, thanks for the pull request, and I'm sorry the interface threw you off at first. I originally designed this whole package as a cleaner drop-in replacement for another system that used the same read/write interface included here and unfortunately the quirks carried over as well. But you're right in that this should be cleaned up to make more sense in the general case. Let me spend some time on getting this sorted out and making the documentation match as well. Thanks for the input |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It took me some time to debug this. Transfer method worked pretty random when list of integers were converted literally to such string: "[1, 2, 3]" not to binary string :)