fix(security): 2 improvements across 2 files#219
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Command Injection via os.system in build_ui.py - Security: Unsafe Deserialization with pickle.loads in TaskHttp Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Command Injection via os.system in build_ui.py - Security: Unsafe Deserialization with pickle.loads in TaskHttp Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:script/build_ui.py:L9The script
build_ui.pyconstructs a shell command by concatenating user-influenced file paths (root,outName) directly into a string passed toos.system(). While the input comes from filesystem iteration, this pattern is dangerous and could lead to command injection if the script is ever modified to process untrusted paths or if the working directory contains maliciously named files.Solution
Use
subprocess.run()with a list of arguments instead ofos.system()to avoid shell injection. Ensure all paths are properly sanitized or usepathlibto handle paths safely.Changes
script/build_ui.py(modified)src/task/task_http.py(modified)