Skip to content

⚡ Bolt: [performance improvement] optimize PATH splitting allocation #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonythethompson merged 3 commits into from
Jul 25, 2026
+11 −2
Merged

⚡ Bolt: [performance improvement] optimize PATH splitting allocation #124

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8841fd9
⚡ Bolt: optimize PATH splitting allocation
google-labs-jules[bot] Jul 24, 2026
ac7576c
📝 Add docstrings to `bolt-optimize-path-split-292288705065865692`
coderabbitai[bot] Jul 25, 2026
02a3e10
⚡ Bolt: optimize PATH splitting allocation
google-labs-jules[bot] Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions QuickShell.Core/Services/PathExecutableLookup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,20 @@
}

var name = Path.GetFileName(fileName.Trim());
foreach (var segment in pathValue.Split(';', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries))
// Performance optimization - avoid string[] and intermediate string allocations
// from pathValue.Split() on long PATH variables. Using AsSpan().Split() with Range
// makes this hot-path executable resolution allocation-free for the segment iteration.
foreach (var range in pathValue.AsSpan().Split(';'))

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This assignment to
range
Loading
is useless, since its value is never read.

@tonythethompson tonythethompson Jul 25, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jules can you commit a change addressing this

{
var segment = pathValue.AsSpan()[range].Trim();
if (segment.IsEmpty)
{
continue;
}

try
{
var candidate = Path.Join(segment, name);
var candidate = Path.Join(segment, name.AsSpan());
if (!File.Exists(candidate))
{
continue;
Expand Down
Loading