Skip to content

⚡ Bolt: [performance improvement] avoid string[] allocations in GetTaskSearchTokens #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonythethompson merged 2 commits into from
Jul 27, 2026
+30 −18
Merged

⚡ Bolt: [performance improvement] avoid string[] allocations in GetTaskSearchTokens #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42defaa
⚡ Bolt: [performance improvement] avoid string[] allocations in GetTa…
google-labs-jules[bot] Jul 27, 2026
71f3804
Merge branch 'master' into bolt-optimize-task-search-tokens-572405395…
tonythethompson Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions QuickShell.Core/Services/RootPaletteSearchIndex.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,25 +285,31 @@ private static int ScoreToken(string? value, string token, int exact, int prefix
return value.Contains(token, StringComparison.OrdinalIgnoreCase) ? contains : 0;
}

// Bolt: Performance optimization - avoid string[] allocations by using SplitAny over ReadOnlySpan
private static string[] GetTaskSearchTokens(string? query)
{
if (string.IsNullOrWhiteSpace(query))
{
return [];
}

return query
.Split([' ', '\t', '\r', '\n'], StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries)
.Select(NormalizeTaskSearchToken)
.Where(token => token.Length > 0 && !IsTaskSearchVerb(token))
.Distinct(StringComparer.OrdinalIgnoreCase)
.ToArray();
var tokens = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
foreach (var range in query.AsSpan().SplitAny([' ', '\t', '\r', '\n']))
{
var tokenSpan = NormalizeTaskSearchToken(query.AsSpan(range).Trim());
if (tokenSpan.Length > 0 && !IsTaskSearchVerb(tokenSpan))
{
tokens.Add(tokenSpan.ToString());
}
}

return tokens.ToArray();
}

private static string NormalizeTaskSearchToken(string token) =>
token.Trim('\'', '"', '`', ',', '.', ':', ';', '(', ')', '[', ']', '{', '}');
private static ReadOnlySpan<char> NormalizeTaskSearchToken(ReadOnlySpan<char> token) =>
token.Trim("'\"`,.:;()[]{}".AsSpan());

private static bool IsTaskSearchVerb(string token) =>
private static bool IsTaskSearchVerb(ReadOnlySpan<char> token) =>
token.Equals("run", StringComparison.OrdinalIgnoreCase) ||
token.Equals("open", StringComparison.OrdinalIgnoreCase) ||
token.Equals("start", StringComparison.OrdinalIgnoreCase) ||
Expand Down
24 changes: 15 additions & 9 deletions QuickShell.Core/Services/WorkspaceRepositorySnapshot.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,25 +288,31 @@ private static int ScoreToken(string? value, string token, int exact, int prefix
return trimmed.Contains(token, StringComparison.OrdinalIgnoreCase) ? contains : 0;
}

// Bolt: Performance optimization - avoid string[] allocations by using SplitAny over ReadOnlySpan
private static string[] GetTaskSearchTokens(string? query)
{
if (string.IsNullOrWhiteSpace(query))
{
return [];
}

return query
.Split([' ', '\t', '\r', '\n'], StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries)
.Select(NormalizeTaskSearchToken)
.Where(token => token.Length > 0 && !IsTaskSearchVerb(token))
.Distinct(StringComparer.OrdinalIgnoreCase)
.ToArray();
var tokens = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
foreach (var range in query.AsSpan().SplitAny([' ', '\t', '\r', '\n']))
{
var tokenSpan = NormalizeTaskSearchToken(query.AsSpan(range).Trim());
if (tokenSpan.Length > 0 && !IsTaskSearchVerb(tokenSpan))
{
tokens.Add(tokenSpan.ToString());
}
}

return tokens.ToArray();
}

private static string NormalizeTaskSearchToken(string token) =>
token.Trim('\'', '"', '`', ',', '.', ':', ';', '(', ')', '[', ']', '{', '}');
private static ReadOnlySpan<char> NormalizeTaskSearchToken(ReadOnlySpan<char> token) =>
token.Trim("'\"`,.:;()[]{}".AsSpan());

private static bool IsTaskSearchVerb(string token) =>
private static bool IsTaskSearchVerb(ReadOnlySpan<char> token) =>
token.Equals("run", StringComparison.OrdinalIgnoreCase) ||
token.Equals("open", StringComparison.OrdinalIgnoreCase) ||
token.Equals("start", StringComparison.OrdinalIgnoreCase) ||
Expand Down
Loading