Fix: [for cherry-picking] Preserved macOS elevation metadata, prevented

[qodo-code-review]

Fixed Findings

• Confirm companion helper export
• Preserve elevation metadata on macOS
• Ignore separator-only remapped layouts
• Keep launch group type private
• Preserve inherited Mac terminal hosts
• Propagate unexpected transfer failures
• Validate layout envelope versions
• Detach debounced flush from lock context

Automated fix from agentic review of #133

Powered by Qodo

---

Summary by cubic

Preserves macOS elevation metadata when editing workspaces and hardens import logic to avoid bad layouts and unsupported versions.

• Bug Fixes
  • macOS: keep existing runAsAdmin when saving a workspace and stop force-disabling it on launches.
  • Import: reject payloads with a version higher than SCHEMA_VERSION and skip remapped layouts that contain only separators.

^{Written for commit f0d00d2. Summary will update on new commits.}

[sourcery-ai]

Hey - I've left some high level feedback:

• The new Windows transfer dialog error handling now rethrows most errors; consider ensuring callers explicitly handle these exceptions or preserve some logging so failures don’t silently bubble up without context.
• For the macOS transfer dialog, errors are now swallowed and null is returned; consider retaining at least minimal logging so unexpected script failures can still be diagnosed in production.
• The "same-as-previous" terminal token is introduced as a magic string; it may be worth centralizing this as a constant or constrained type to avoid typos and to make the intent clearer at the call sites.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new Windows transfer dialog error handling now rethrows most errors; consider ensuring callers explicitly handle these exceptions or preserve some logging so failures don’t silently bubble up without context.
- For the macOS transfer dialog, errors are now swallowed and `null` is returned; consider retaining at least minimal logging so unexpected script failures can still be diagnosed in production.
- The "same-as-previous" terminal token is introduced as a magic string; it may be worth centralizing this as a constant or constrained type to avoid typos and to make the intent clearer at the call sites.

Fix all in Cursor

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}