Fix: [for cherry-picking] Added local Git remote fallback, narrowed fil - #138
Fix: [for cherry-picking] Added local Git remote fallback, narrowed fil#138qodo-code-review[bot] wants to merge 3 commits into
Conversation
- Narrow path query stat errors - Propagate unexpected targeted search errors - Add cancellation to targeted scans
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="QuickShell.Raycast/src/components/discover-git-repos-view.tsx" line_range="118-120" />
<code_context>
- } catch {
- if (!cancelled) {
- setTargetedSearch({ query, repos: [] });
+ } catch (error) {
+ if (!cancelled && !controller.signal.aborted) {
+ throw error;
}
} finally {
</code_context>
<issue_to_address>
**issue (bug_risk):** Re-throwing inside an un-awaited async function will likely cause unhandled promise rejections.
Because this async IIFE is invoked with `void`, its promise is never awaited. Re-throwing in the `catch` will therefore become an unhandled rejection, bypassing React error boundaries and any upstream error handling. If you want the error to be handled, move the async/await to a caller that can catch it or route it through centralized error reporting instead of throwing here. If you only want to ignore abort-related errors, consider restoring the previous `setTargetedSearch({ query, repos: [] })` behavior or logging the error without throwing.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| } catch (error) { | ||
| if (!cancelled && !controller.signal.aborted) { | ||
| throw error; |
There was a problem hiding this comment.
issue (bug_risk): Re-throwing inside an un-awaited async function will likely cause unhandled promise rejections.
Because this async IIFE is invoked with void, its promise is never awaited. Re-throwing in the catch will therefore become an unhandled rejection, bypassing React error boundaries and any upstream error handling. If you want the error to be handled, move the async/await to a caller that can catch it or route it through centralized error reporting instead of throwing here. If you only want to ignore abort-related errors, consider restoring the previous setTargetedSearch({ query, repos: [] }) behavior or logging the error without throwing.
Fixed Findings
Automated fix from agentic review of #137
Powered by Qodo
Summary by cubic
Restore local Git remote fallback in workspace discovery so
repoUrlis set when the seed doesn’t provide a remote. This fixes broken repo-linked actions for locally cloned projects.Written for commit e818555. Summary will update on new commits.