ci: add a production-build smoke job#48
Open
tonytino wants to merge 1 commit into
Open
Conversation
Playwright's webServer runs `pnpm dev`, so E2E never exercises the production build — and the template has shipped two prod-only breakages that dev hid (stylesheet 404 after build; a missing ?url asset import). Add a `build-smoke` job to ci.yml that runs `pnpm build && pnpm start`, then asserts the homepage returns 200 and its stylesheet asset actually resolves. This targets exactly that failure class. No database is required (the home route's server function needs none, and env/db are lazy). Verified locally: built, served via `node .output/server/index.mjs`, homepage returned 200, the served stylesheet (/_build/assets/app-<hash>.css) resolved 200. Documented the job in docs/agents/testing.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45.
Playwright's
webServerrunspnpm dev, so E2E never touches the production build. The template has already shipped two prod-only breakages that dev hid (stylesheet 404 after build; a missing?urlasset import). This adds a guardrail for that whole class.Change
New
build-smokejob inci.yml:pnpm build && pnpm start, then assert:<link>in the served HTML resolves (the exact failure mode we hit).No database needed — the home route's server function requires none, and
env/dbare lazy.Verification
Validated locally end-to-end: built, served via the production server, homepage
200, served stylesheet (/_build/assets/app-<hash>.css) resolved200.templates.test.ts(which readsci.yml) still passes. The new job is exercised by this PR's own CI run.🤖 Generated with Claude Code