This repository was archived by the owner on May 18, 2025. It is now read-only.
Fixing the build and adding an ability to pass arbitrary parameters to quickfix#5
Open
mprusakov wants to merge 1 commit intotools4j:masterfrom
mprusakov:master
Open
Fixing the build and adding an ability to pass arbitrary parameters to quickfix#5mprusakov wants to merge 1 commit intotools4j:masterfrom mprusakov:master
mprusakov wants to merge 1 commit intotools4j:masterfrom
mprusakov:master
Conversation
Member
|
Thanks Michail. Will review. |
terzerm
reviewed
Feb 7, 2023
| final Map additionalQuickFixProperties) { | ||
| this.fixSpecification = fixSpecification; | ||
| this.properties = properties; | ||
| this.additionalQuickFixProperties = additionalQuickFixProperties; |
Member
There was a problem hiding this comment.
null checks here (for all 3 actually)
terzerm
reviewed
Feb 7, 2023
| *.iml | ||
| **/.idea/* | ||
| **/build | ||
| */src/generated |
Member
There was a problem hiding this comment.
we actually should generate into the build folder, not src
Member
|
looks good mostly, only minor comments if possible we should change source generation to build folder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.