edited dummy protocols#6
Open
osn07 wants to merge 3 commits intotoolsforexperiments:mainfrom
Open
Conversation
…els from individual file classes. some classes at naming conflicts with fitfuncs.generic, so imports do not currently have consistent naming across files protocol
marcosfrenkel
requested changes
Apr 9, 2026
|
|
||
| sweep = sweep_parameter("frequencies", frequencies, record_as(generate, "signal")) | ||
| generator = GaussianDataGen(x0=center, sigma=self._SIM_SIGMA, A=self._SIM_AMP, of=0, noise_std=self._SIM_NOISE_AMP) | ||
| sweep = sweep_parameter("frequencies", frequencies) * Sweep(record_as(generator.generate(frequencies), "signal")) |
Contributor
There was a problem hiding this comment.
Keep it under a single sweep instead of zipping
|
|
||
| sweep = sweep_parameter("gains", gains, record_as(generator.generate, "signal")) | ||
| generator = PowerRabiDataGen(pi_amp=self._SIM_PI_AMP, noise_std=self._SIM_NOISE_AMP) | ||
| sweep = sweep_parameter("gains", gains) * Sweep(record_as(generator.generate(gains), "signal")) |
Contributor
There was a problem hiding this comment.
Keep it under a single sweep instead of zipping
| ) | ||
|
|
||
| sweep = sweep_parameter("frequencies", frequencies + self.readout_lo(), record_as(generator.generate, "signal")) | ||
| frequencies = np.linspace(self.start_frequency(), self.end_frequency(), int(self.steps())) + self.readout_freq() |
Contributor
There was a problem hiding this comment.
why the + self.readout_freq()?
| sweep = sweep_parameter("frequencies", frequencies + self.readout_lo(), record_as(generator.generate, "signal")) | ||
| frequencies = np.linspace(self.start_frequency(), self.end_frequency(), int(self.steps())) + self.readout_freq() | ||
| generator = HangerResonator(f0=self._SIM_F0, Qc=self._SIM_QC, Qi=self._SIM_QI, A=self._SIM_A, phi=self._SIM_PHI, noise_std=self._SIM_NOISE_AMP) | ||
| sweep = sweep_parameter("frequencies", frequencies) * Sweep(record_as(generator.generate(frequencies), "signal")) |
Contributor
There was a problem hiding this comment.
Keep it under a single sweep instead of zipping
|
|
||
| frequencies = np.linspace(self.start_freq(), self.end_freq(), int(self.steps())) | ||
| generator = LorentzianDataGen(x0=self._DUMMY_F_Q, gamma=self._DUMMY_GAMMA, A=self._DUMMY_A, of=0, noise_std=self._DUMMY_NOISE_AMP) | ||
| sweep = sweep_parameter('frequencies', frequencies) * Sweep(record_as(generator.generate(frequencies), 'signal')) |
Contributor
There was a problem hiding this comment.
Keep it under a single sweep instead of zipping
| generator = LorentzianDataGen(x0=self._DUMMY_F_Q, gamma=self._DUMMY_GAMMA, A=self._DUMMY_A, of=0, noise_std=self._DUMMY_NOISE_AMP) | ||
| sweep = sweep_parameter('frequencies', frequencies) * Sweep(record_as(generator.generate(frequencies), 'signal')) | ||
| loc, _ = run_and_save_sweep(sweep, "data", self.name) | ||
| logger.info("Dummy saturation spectroscopy measurement complete.") |
Contributor
There was a problem hiding this comment.
keep this message, it is more descriptive.
| + self._SIM_NOISE_AMP * (np.random.randn() + 1j * np.random.randn())) | ||
| sweep = sweep_parameter("delays", delays, record_as(signal_gen, "signal")) | ||
| generator = ExponentialDecayingSine(A=self._SIM_AMP, f=self._SIM_DETUNING, phi=0, tau=self._SIM_T2E, of=0, noise_std=self._SIM_NOISE_AMP) | ||
| sweep = sweep_parameter("delays", delays) * Sweep(record_as(generator.generate(delays), "signal")) |
Contributor
There was a problem hiding this comment.
Keep it under a single sweep instead of zipping
| + self._SIM_NOISE_AMP * (np.random.randn() + 1j * np.random.randn())) | ||
| sweep = sweep_parameter("delays", delays, record_as(signal_gen, "signal")) | ||
| generator = ExponentialDecayingSine(A=self._SIM_AMP, f=self._SIM_DETUNING, phi=0, tau=self._SIM_T2R, of=0, noise_std=self._SIM_NOISE_AMP) | ||
| sweep = sweep_parameter("delays", delays) * Sweep(record_as(generator.generate(delays), "signal")) |
Contributor
There was a problem hiding this comment.
Keep it under a single sweep instead of zipping
| + self._SIM_NOISE_AMP * (np.random.randn() + 1j * np.random.randn())) | ||
| sweep = sweep_parameter("delays", delays, record_as(signal_gen, "signal")) | ||
| generator = ExponentialDecayDataGen(A=self._SIM_AMP, tau=self._SIM_T1, of=0, noise_std=self._SIM_NOISE_AMP) | ||
| sweep = sweep_parameter("delays", delays) * Sweep(record_as(generator.generate(delays), "signal")) |
Contributor
There was a problem hiding this comment.
Keep it under a single sweep instead of zipping
… using lambda functions). hanger resonator and sat spec moved from datagen in labcore repo to cqedtoolbox repo because not generic.
marcosfrenkel
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implemented measure_dummy to use the respective datagen class instead of individual modeling classes in protocol files. I had to hard code some getters for res_spec_vs_gain.py (testing purposes), but I commented them out for now.