-
Notifications
You must be signed in to change notification settings - Fork 0
Partition canonical api spec output #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
17d9968
feature: sha256 ν΄μ μμ± λ° stableStringify ν¨μ μΆκ°
toothlessdev 59e0522
chore: @types/node ν¨ν€μ§μμ‘΄μ± μΆκ°
toothlessdev 84b7030
feature: tag[0] κΈ°λ° νν°μ
λ μ λ΅ λμ
toothlessdev d9d8948
feature: HttpMethod κΈ°λ° νν°μ
λ μ λ΅ λμ
toothlessdev 0ab4958
fix: μ€μ²©λ κ°μ²΄ λ° λ°°μ΄λ μ λ ¬λλλ‘ μμ
toothlessdev 5c08992
test: λ¬Έμμ΄ λμ JSON.stringify κ²°κ³Όλ‘ λ체νμ¬ ν
μ€νΈ κ°λ
μ± ν₯μ
toothlessdev ff37785
test: μλͺ»λ ν
μ€νΈλͺ
μμ
toothlessdev f3bffb1
test: tag κ° μλ μν©μΌλ ν
μ€νΈ μΌμ΄μ€ μΆκ°
toothlessdev dc6ab81
test: sha256 ν΄μ±μ λν deterministic ν
μ€νΈ
toothlessdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
packages/patchlogr-core/src/partition/__tests__/partitionByMethod.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| import type { CanonicalSpec } from "@patchlogr/types"; | ||
| import { describe, expect, test } from "vitest"; | ||
| import { partitionByMethod } from "../partitionByMethod"; | ||
|
|
||
| describe("partitionByMethod", () => { | ||
| test("should group by HTTPMethod", () => { | ||
| const spec: CanonicalSpec = { | ||
| operations: { | ||
| "GET /user": { | ||
| key: "GET /user", | ||
| doc: { tags: ["user"] }, | ||
| method: "GET", | ||
| path: "/user", | ||
| request: { params: [] }, | ||
| responses: {}, | ||
| }, | ||
| "GET /user/{userId}": { | ||
| key: "GET /user/{userId}", | ||
| doc: { tags: ["user"] }, | ||
| method: "GET", | ||
| path: "/user/{userId}", | ||
| request: { params: [] }, | ||
| responses: {}, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| const partitions = partitionByMethod(spec).partitions; | ||
toothlessdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| expect(partitions).toHaveLength(1); | ||
| expect(partitions.get("GET")).toHaveLength(2); | ||
| expect(partitions.get("GET")?.[0]?.operationKey).toBe("GET /user"); | ||
| expect(partitions.get("GET")?.[1]?.operationKey).toBe( | ||
| "GET /user/{userId}", | ||
| ); | ||
| }); | ||
|
|
||
| test("should group by multiple HTTPMethods", () => { | ||
| const spec: CanonicalSpec = { | ||
| operations: { | ||
| "GET /user": { | ||
| key: "GET /user", | ||
| doc: { tags: ["user"] }, | ||
| method: "GET", | ||
| path: "/user", | ||
| request: { params: [] }, | ||
| responses: {}, | ||
| }, | ||
| "POST /auth/login": { | ||
| key: "POST /auth/login", | ||
| doc: { tags: ["auth"] }, | ||
| method: "POST", | ||
| path: "/auth/login", | ||
| request: { params: [] }, | ||
| responses: {}, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| const partitions = partitionByMethod(spec).partitions; | ||
|
|
||
| expect(partitions).toHaveLength(2); | ||
| expect(partitions.get("GET")).toHaveLength(1); | ||
| expect(partitions.get("POST")).toHaveLength(1); | ||
| expect(partitions.get("GET")?.[0]?.operationKey).toBe("GET /user"); | ||
| expect(partitions.get("POST")?.[0]?.operationKey).toBe( | ||
| "POST /auth/login", | ||
| ); | ||
| }); | ||
| }); | ||
92 changes: 92 additions & 0 deletions
92
packages/patchlogr-core/src/partition/__tests__/partitionByTag.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| import type { CanonicalSpec } from "@patchlogr/types"; | ||
| import { describe, expect, test } from "vitest"; | ||
| import { DEFAULT_TAG, partitionByTag } from "../partitionByTag"; | ||
|
|
||
| describe("partitionByTag", () => { | ||
| test("should group by first tag", () => { | ||
| const spec: CanonicalSpec = { | ||
| operations: { | ||
| "GET /user": { | ||
| key: "GET /user", | ||
| doc: { tags: ["user"] }, | ||
| method: "GET", | ||
| path: "/user", | ||
| request: { params: [] }, | ||
| responses: {}, | ||
| }, | ||
| "GET /user/{userId}": { | ||
| key: "GET /user/{userId}", | ||
| doc: { tags: ["user"] }, | ||
| method: "GET", | ||
| path: "/user/{userId}", | ||
| request: { params: [] }, | ||
| responses: {}, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| const partitions = partitionByTag(spec).partitions; | ||
toothlessdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| expect(partitions).toHaveLength(1); | ||
| expect(partitions.get("user")).toHaveLength(2); | ||
| expect(partitions.get("user")?.[0]?.operationKey).toBe("GET /user"); | ||
| expect(partitions.get("user")?.[1]?.operationKey).toBe( | ||
| "GET /user/{userId}", | ||
| ); | ||
| }); | ||
toothlessdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| test("should group by multiple tags", () => { | ||
| const spec: CanonicalSpec = { | ||
| operations: { | ||
| "GET /user": { | ||
| key: "GET /user", | ||
| doc: { tags: ["user"] }, | ||
| method: "GET", | ||
| path: "/user", | ||
| request: { params: [] }, | ||
| responses: {}, | ||
| }, | ||
| "POST /auth/login": { | ||
| key: "POST /auth/login", | ||
| doc: { tags: ["auth"] }, | ||
| method: "POST", | ||
| path: "/auth/login", | ||
| request: { params: [] }, | ||
| responses: {}, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| const partitions = partitionByTag(spec).partitions; | ||
|
|
||
| expect(partitions).toHaveLength(2); | ||
| expect(partitions.get("user")).toHaveLength(1); | ||
| expect(partitions.get("auth")).toHaveLength(1); | ||
| expect(partitions.get("user")?.[0]?.operationKey).toBe("GET /user"); | ||
| expect(partitions.get("auth")?.[0]?.operationKey).toBe( | ||
| "POST /auth/login", | ||
| ); | ||
| }); | ||
|
|
||
| test("should group into default tag if tag not exists", () => { | ||
| const spec: CanonicalSpec = { | ||
| operations: { | ||
| "GET /user": { | ||
| key: "GET /user", | ||
| doc: { tags: [] }, | ||
| method: "GET", | ||
| path: "/user", | ||
| request: { params: [] }, | ||
| responses: {}, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| const partitions = partitionByTag(spec).partitions; | ||
|
|
||
| expect(partitions).toHaveLength(1); | ||
| expect(partitions.get(DEFAULT_TAG)).toHaveLength(1); | ||
| expect(partitions.get(DEFAULT_TAG)?.[0]?.operationKey).toBe( | ||
| "GET /user", | ||
| ); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| export type PartitionManifest = { | ||
| key: string; | ||
| hash: string; | ||
| }; | ||
toothlessdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| export type Partition = { | ||
| hash: string; | ||
| operationKey: string; | ||
| }; | ||
|
|
||
| export type PartitionedSpec = { | ||
| metadata: Record<string, unknown>; | ||
| partitions: Map<string, Partition[]>; | ||
| }; | ||
toothlessdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
26 changes: 26 additions & 0 deletions
26
packages/patchlogr-core/src/partition/partitionByMethod.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import type { CanonicalSpec, HTTPMethod } from "@patchlogr/types"; | ||
| import type { Partition, PartitionedSpec } from "./partition"; | ||
|
|
||
| import { createSHA256Hash } from "../utils/createHash"; | ||
| import { stableStringify } from "../utils/stableStringify"; | ||
|
|
||
toothlessdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| export function partitionByMethod(spec: CanonicalSpec): PartitionedSpec { | ||
| const partitions = new Map<HTTPMethod, Partition[]>(); | ||
|
|
||
| Object.entries(spec.operations).forEach(([key, operation]) => { | ||
| const hash = createSHA256Hash(stableStringify(operation)); | ||
|
|
||
| if (!partitions.has(operation.method)) | ||
| partitions.set(operation.method, [{ hash, operationKey: key }]); | ||
| else | ||
| partitions.get(operation.method)?.push({ hash, operationKey: key }); | ||
toothlessdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }); | ||
|
|
||
| return { | ||
| metadata: { | ||
| ...spec.info, | ||
| ...spec.security, | ||
| }, | ||
| partitions, | ||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import type { CanonicalSpec } from "@patchlogr/types"; | ||
| import type { Partition, PartitionedSpec } from "./partition"; | ||
|
|
||
| import { createSHA256Hash } from "../utils/createHash"; | ||
| import { stableStringify } from "../utils/stableStringify"; | ||
|
|
||
toothlessdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| export const DEFAULT_TAG = "__DEFAULT__"; | ||
|
|
||
toothlessdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| export function partitionByTag(spec: CanonicalSpec): PartitionedSpec { | ||
| const partitions = new Map<string, Partition[]>(); | ||
|
|
||
| Object.entries(spec.operations).forEach(([key, operation]) => { | ||
| const tag = operation.doc?.tags?.[0] || DEFAULT_TAG; | ||
toothlessdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| const hash = createSHA256Hash(stableStringify(operation)); | ||
|
|
||
toothlessdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if (!partitions.has(tag)) | ||
| partitions.set(tag, [{ hash, operationKey: key }]); | ||
| else partitions.get(tag)?.push({ hash, operationKey: key }); | ||
| }); | ||
|
|
||
| return { | ||
| metadata: { | ||
| ...spec.info, | ||
| ...spec.security, | ||
| }, | ||
| partitions, | ||
| }; | ||
| } | ||
11 changes: 11 additions & 0 deletions
11
packages/patchlogr-core/src/utils/__tests__/createHash.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { describe, test, expect } from "vitest"; | ||
| import { createSHA256Hash } from "../createHash"; | ||
|
|
||
| describe("createHash", () => { | ||
| describe("createSHA256Hash", () => { | ||
| test("sha256 must be deterministic", () => { | ||
| const hash = createSHA256Hash("test"); | ||
| expect(hash).toBe(createSHA256Hash("test")); | ||
| }); | ||
| }); | ||
| }); |
114 changes: 114 additions & 0 deletions
114
packages/patchlogr-core/src/utils/__tests__/stableStringify.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| import { describe, test, expect } from "vitest"; | ||
| import { stableStringify } from "../stableStringify"; | ||
|
|
||
| describe("stableStringify", () => { | ||
| test("should stringify json", () => { | ||
| expect(stableStringify({ a: 1, b: 2, c: 3 })).toBe( | ||
| JSON.stringify({ a: 1, b: 2, c: 3 }), | ||
| ); | ||
| }); | ||
|
|
||
| test("should stringify json in a stable order", () => { | ||
| const obj1 = { a: 1, b: 2 }; | ||
| const obj2 = { b: 2, a: 1 }; | ||
|
|
||
| expect(stableStringify(obj1)).toBe(stableStringify(obj2)); | ||
| }); | ||
|
|
||
| test("should stringify nested objects with stable key order", () => { | ||
| const obj1 = { a: 1, nested: { x: 10, y: 20 } }; | ||
| const obj2 = { nested: { y: 20, x: 10 }, a: 1 }; | ||
|
|
||
| expect(stableStringify(obj1)).toBe(stableStringify(obj2)); | ||
| }); | ||
|
|
||
| test("should stringify deeply nested objects with stable key order", () => { | ||
| const obj1 = { | ||
| level1: { | ||
| level2: { | ||
| c: 3, | ||
| b: 2, | ||
| a: 1, | ||
| }, | ||
| }, | ||
| }; | ||
| const obj2 = { | ||
| level1: { | ||
| level2: { | ||
| a: 1, | ||
| b: 2, | ||
| c: 3, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| expect(stableStringify(obj1)).toBe(stableStringify(obj2)); | ||
| }); | ||
|
|
||
| test("should stringify arrays containing objects with stable key order", () => { | ||
| const obj1 = { | ||
| items: [ | ||
| { z: 3, y: 2, x: 1 }, | ||
| { c: "c", b: "b", a: "a" }, | ||
| ], | ||
| }; | ||
| const obj2 = { | ||
| items: [ | ||
| { x: 1, y: 2, z: 3 }, | ||
| { a: "a", b: "b", c: "c" }, | ||
| ], | ||
| }; | ||
|
|
||
| expect(stableStringify(obj1)).toBe(stableStringify(obj2)); | ||
| }); | ||
|
|
||
| test("should handle null and primitive values correctly", () => { | ||
| const obj1 = { b: null, a: 1, c: "string", d: true }; | ||
| const obj2 = { d: true, c: "string", a: 1, b: null }; | ||
|
|
||
| expect(stableStringify(obj1)).toBe(stableStringify(obj2)); | ||
| }); | ||
|
|
||
| test("should produce deterministic output for canonical spec hashing", () => { | ||
| const spec1 = { | ||
| operationId: "getUser", | ||
| responses: { | ||
| "200": { | ||
| schema: { | ||
| type: "object", | ||
| properties: { name: {}, id: {} }, | ||
| }, | ||
| }, | ||
| }, | ||
| parameters: [{ name: "id", in: "path", required: true }], | ||
| }; | ||
| const spec2 = { | ||
| parameters: [{ required: true, in: "path", name: "id" }], | ||
| responses: { | ||
| "200": { | ||
| schema: { | ||
| properties: { id: {}, name: {} }, | ||
| type: "object", | ||
| }, | ||
| }, | ||
| }, | ||
| operationId: "getUser", | ||
| }; | ||
|
|
||
| expect(stableStringify(spec1)).toBe(stableStringify(spec2)); | ||
| }); | ||
|
|
||
| test("should output nested object keys in sorted order", () => { | ||
| const obj = { b: 2, a: { z: 1, y: 2 } }; | ||
| const result = stableStringify(obj); | ||
|
|
||
| expect(result).toBe(JSON.stringify({ a: { y: 2, z: 1 }, b: 2 })); | ||
| }); | ||
|
|
||
| test("should sort keys in arrays of objects", () => { | ||
| const obj = { items: [{ b: 1, a: 2 }] }; | ||
| const result = stableStringify(obj); | ||
|
|
||
| expect(result).toBe(JSON.stringify({ items: [{ a: 2, b: 1 }] })); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import crypto from "crypto"; | ||
|
|
||
toothlessdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| export function createSHA256Hash(data: string) { | ||
| return crypto.createHash("sha256").update(data).digest("hex"); | ||
| } | ||
toothlessdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.