feat: add framework for listing updated components#1147
Draft
GideonBear wants to merge 21 commits intotopgrade-rs:mainfrom
Draft
feat: add framework for listing updated components#1147GideonBear wants to merge 21 commits intotopgrade-rs:mainfrom
GideonBear wants to merge 21 commits intotopgrade-rs:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| // 2. Update the installed tools | ||
| // TODO: include this in `updated` |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
lnksz
reviewed
Aug 8, 2025
lnksz
reviewed
Aug 8, 2025
GideonBear
changed the title
2 tasks
rubiin
approved these changes
Nov 28, 2025
Member
Author
|
See discussion in #943 |
barkleesanders
added a commit
to barkleesanders/topgrade
that referenced
this pull request
Mar 8, 2026
From PR topgrade-rs#1147. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
barkleesanders
added a commit
to barkleesanders/topgrade
that referenced
this pull request
Mar 8, 2026
Add print_updated_components_summary() to terminal.rs that collects version changes from all steps and displays them in a dedicated section after the main summary. Builds on the UpdatedComponents framework from PR topgrade-rs#1147. Fixes topgrade-rs#943. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Closes #943 (I am planning to open a tracking issue for implementing this for all steps where it is possible if this is merged.)
uv(self-updating only for now)What do you think @SteveLauC? This is non-disruptive for steps that don't yet or can't support it, but opens up the possibility to implement this for steps where it is very useful. Note that for some steps, machine-readable output is available (e.g.
apt-get) and can be used instead of regexes. We can also PR to the tools themselves to support outputting in a machine-readable format. (maybe a good idea foruv, which already supports--output-format=jsonon some commands)Example: (
cinnamon_spicesincluded to show what it looks like for a step that does not support it (yet))Standards checklist
CONTRIBUTING.md