Skip to content

feat(step): update KDE Plasmoids using libplasmoid-updater#1804

Open
uwuclxdy wants to merge 1 commit intotopgrade-rs:mainfrom
uwuclxdy:plasmoid-updater
Open

feat(step): update KDE Plasmoids using libplasmoid-updater#1804
uwuclxdy wants to merge 1 commit intotopgrade-rs:mainfrom
uwuclxdy:plasmoid-updater

Conversation

@uwuclxdy
Copy link
Copy Markdown
Contributor

@uwuclxdy uwuclxdy commented Feb 28, 2026

What does this PR do

Adds integration with libplasmoid-updater to update KDE Plasma components (plasmoids) user and system-wide.
Fixes #1020

It can also be used as a standalone program for those that wish to test (or just use) the library itself: https://github.com/uwuclxdy/plasmoid-updater

Standards checklist

  • The PR title is descriptive
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself
  • If this PR introduces new user-facing messages they are translated

For new steps

  • Optional: Topgrade skips this step where needed (needs testing)
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

My best try at this ig. Needs testing (edge cases, error handling). As far as library is concerned, the code is a messy and worse I'd like it to be, but it works! It successfully finds and updates components that either Discover or Apdatify sometimes doesn't find.

Comment thread src/steps/os/linux.rs Outdated
@GideonBear
Copy link
Copy Markdown
Member

FYI the MSRV check in CI will fail because of the current MSRV of 1.84 which will be bumped to 1.88 in v17 (which I will release soon, I hope). You don't have to change the edition and you can ignore the MSRV check CI for now.
plasmoid-updater does compile with Rust 1.88, I checked

@uwuclxdy
Copy link
Copy Markdown
Contributor Author

uwuclxdy commented Mar 1, 2026

@GideonBear yeah, i fixed the ordering problem tho. they were ordered but not in the right place in proportion to the entire enum

@uwuclxdy
Copy link
Copy Markdown
Contributor Author

uwuclxdy commented Mar 1, 2026

@uwuclxdy uwuclxdy marked this pull request as ready for review March 1, 2026 16:29
@uwuclxdy uwuclxdy marked this pull request as draft March 1, 2026 17:06
@uwuclxdy uwuclxdy marked this pull request as ready for review March 1, 2026 17:30
Copy link
Copy Markdown
Member

@GideonBear GideonBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, I'll need to review plasmoid-updater of course but the API looks nice!

Comment thread Cargo.toml Outdated
Comment thread src/steps/os/linux.rs Outdated
Comment thread src/steps/os/linux.rs Outdated
Comment thread src/steps/os/linux.rs Outdated
Comment thread src/steps/os/linux.rs
@GideonBear GideonBear changed the title feat(step): libplasmoid-updater integration feat(step): update KDE Plasmoids using libplasmoid-updater Mar 2, 2026
Comment thread src/steps/os/linux.rs Outdated
@uwuclxdy uwuclxdy requested a review from GideonBear March 4, 2026 21:18
barkleesanders added a commit to barkleesanders/topgrade that referenced this pull request Mar 8, 2026
From PR topgrade-rs#1804 by uwuclxdy.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

# Conflicts:
#	Cargo.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for upgrading plasmoids

2 participants