Skip to content

feat!: expand environment variables in config paths and git repos#1806

Merged
GideonBear merged 5 commits intotopgrade-rs:v18from
uwuclxdy:fix-path-expand
Apr 5, 2026
Merged

feat!: expand environment variables in config paths and git repos#1806
GideonBear merged 5 commits intotopgrade-rs:v18from
uwuclxdy:fix-path-expand

Conversation

@uwuclxdy
Copy link
Copy Markdown
Contributor

What does this PR do

Replaces shellexpand::tilde() with shellexpand::full() as discussed in #921.
Closes #921.

Standards checklist

  • The PR title is descriptive
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself

Comment thread src/steps/git.rs Outdated
@GideonBear GideonBear changed the title fix: replace shellexpand::tilde() with shellexpand::full() to support environment variables in config paths feat: replace shellexpand::tilde() with shellexpand::full() to support environment variables in config paths Mar 1, 2026
@GideonBear GideonBear changed the title feat: replace shellexpand::tilde() with shellexpand::full() to support environment variables in config paths feat: expand environment variables in config paths and git repos Mar 1, 2026
@GideonBear
Copy link
Copy Markdown
Member

This is technically a breaking change (/some/pa$th/here will now error, while it can be a real path name) so I will delay it until v18

@GideonBear GideonBear changed the title feat: expand environment variables in config paths and git repos feat!: expand environment variables in config paths and git repos Mar 1, 2026
@GideonBear GideonBear added this to the v18.0.0 milestone Mar 1, 2026
@GideonBear
Copy link
Copy Markdown
Member

The release notes should mention the migration path, which is replacing $ with $$

Copy link
Copy Markdown
Member

@GideonBear GideonBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for merge in v18, thanks!

@GideonBear GideonBear self-requested a review March 1, 2026 16:20
barkleesanders added a commit to barkleesanders/topgrade that referenced this pull request Mar 8, 2026
From PR topgrade-rs#1806 by uwuclxdy.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@GideonBear GideonBear changed the base branch from main to v18 April 5, 2026 08:59
@GideonBear GideonBear merged commit 73a1828 into topgrade-rs:v18 Apr 5, 2026
20 checks passed
GideonBear added a commit that referenced this pull request Apr 25, 2026
)

Co-authored-by: Gideon <dig-sultry-sedate@duck.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional Git repositories not expanding environment variables like $HOME

2 participants