Skip to content

retry puts with if-match/if-none-match #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jerguslejko wants to merge 2 commits into from
Closed

retry puts with if-match/if-none-match #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f88c7e3
WIP
jerguslejko Mar 4, 2026
10522c5
WIP
jerguslejko Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/aws/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,13 @@ impl ObjectStore for AmazonS3 {
(PutMode::Overwrite, _) => request.idempotent(true).do_put().await,
(PutMode::Create, S3ConditionalPut::Disabled) => Err(Error::NotImplemented),
(PutMode::Create, S3ConditionalPut::ETagMatch) => {
match request.header(&IF_NONE_MATCH, "*").do_put().await {
match request
.header(&IF_NONE_MATCH, "*")
// Conditional put with If-None-Match is idempotent.
.idempotent(true)
.do_put()
.await
{
// Technically If-None-Match should return NotModified but some stores,
// such as R2, instead return PreconditionFailed
// https://developers.cloudflare.com/r2/api/s3/extensions/#conditional-operations-in-putobject
Expand All @@ -205,6 +211,8 @@ impl ObjectStore for AmazonS3 {
S3ConditionalPut::ETagMatch => {
match request
.header(&IF_MATCH, etag.as_str())
// Conditional PUTs with If-Match are idempotent.
.idempotent(true)
// Real S3 will occasionally report 409 Conflict
// if there are concurrent `If-Match` requests
// in flight, so we need to be prepared to retry
Expand Down
Loading