Fix tag overrides’ default_html preventing real tag usage#199
Open
thibaudcolas wants to merge 1 commit intomainfrom
Open
Fix tag overrides’ default_html preventing real tag usage#199thibaudcolas wants to merge 1 commit intomainfrom
thibaudcolas wants to merge 1 commit intomainfrom
Conversation
Contributor
|
This branch has conflicts that must be resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug with our tag overrides’ support for default values. As implemented currently, we can no longer just let the tag render as normal – the default value would always take precedence, even if unset.
Even though this is a bug fix, I believe it might be sensible to only release this in a major version. Lots of projects might rely on the fact that tags always render
None.Checklist
[ ] I have made corresponding changes to the documentationNot needed[ ] I have added an appropriate CHANGELOG entryWill do this once merged