This repository was archived by the owner on Oct 22, 2019. It is now read-only.
Added 'scope' to ldap.conf, changed operatingsystem to osfamily#36
Open
jtickle wants to merge 3 commits intotorian:masterfrom
Open
Added 'scope' to ldap.conf, changed operatingsystem to osfamily#36jtickle wants to merge 3 commits intotorian:masterfrom
jtickle wants to merge 3 commits intotorian:masterfrom
Conversation
… this case. Was breaking on CentOS before.
jtickle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just needed this particular config item in my work and figured it might be useful to others. The config item is just 'scope' but I called it 'search_scope' because I'm a bit new to puppet and was worried about 'scope' being a problem.
Additionally, on my CentOS boxes, it was looking for ldap::os::CentOS because of the$::operatingsystem variable. I changed this to $ ::osfamily because that reports 'redhat' for centos and is probably the better option here.
Also sorry for this abysmal and janky pull request, I didn't realize updating my repository after making the request would update the request.