Fix line endings, various HidingContainer fixes, missing test deps, GrowingGridLayout validation#12
Open
nphilipp wants to merge 7 commits intotoscawidgets:developfrom
Open
Fix line endings, various HidingContainer fixes, missing test deps, GrowingGridLayout validation#12nphilipp wants to merge 7 commits intotoscawidgets:developfrom
nphilipp wants to merge 7 commits intotoscawidgets:developfrom
Conversation
Necessary to hide stuff if the checkbox is unchecked. Allows using True and False as keys in mappings.
nphilipp
force-pushed
the
develop--nphilipp
branch
from
7f6c857 to
f56cbab
Compare
nphilipp
changed the title
Cf. this change in tw2.core: 1cdab8206dc0009209ff72e8e3f355ee8fa9b0ba MatchValidator broken due to CompoundWidget state
This is necessary so that users of HTML5-capable browsers can submit forms with hidden form fields that have the `required` attribute set (assuming hidden form fields cannot be required because users can't fill them). Needs server-side validation logic to follow suit, i.e. distinguish between hidden and non-hidden form fields depending on the state of the hiding form field.
nphilipp
changed the title
nphilipp
changed the title
HidingContainer fixes, missing test deps, GrowingGridLayout validation
nphilipp
changed the title
HidingContainer fixes, missing test deps, GrowingGridLayout validation
nphilipp
force-pushed
the
develop--nphilipp
branch
from
8fb52c1 to
483561f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally planned this to fix
HidingCheckBox, as it is it doesn't really work well for showing widgets if the checkbox is unchecked, probably due to the different nature of truth values in JS and Python. The rest came up when I tested things out:Some previous commit(s) converted widgets.py to DOS line endings. The first commit reverts that.
In
HidingContainerMixin._validate(), the wrong module was used for raisingValidationError, the second commit fixes this.Normalize
HidingCheckBox.mappingkeys if they are "well-known" truth values (True,"true", 1,False,"false", 0), so the JS mapping keys matches thecheckedstatus of the checkbox.Create a
stateobject inHidingContainerMixin._validate().Allow users to submit forms with hidden fields that have the
requiredattribute set: Assuming that a user can't fill in a form field that is hidden, "hide" therequiredattribute under a different name (and "reveal" it again if the field is unhidden).Addendum (and because this builds on the lineending change):
Add missing 'sieve' test dependency
With a
GrowingGridLayout, the first (hidden, template) child can cause validation to fail, e.g. if a field is marked as required. This change sets itsvalidatormember toNonein order to skip validation for this child.