Conversation
|
|
||
| let curatorMode = false; | ||
| let apiUrl = DEFAULT_API_URL; | ||
| let language: SupportedLanguage = 'en'; |
There was a problem hiding this comment.
I think we should set all three in constants
There was a problem hiding this comment.
they are user-adjustable, thus not constant
There was a problem hiding this comment.
I meant the defaults ;D
So the default apiURL comes from DEFAULT_API_URL in constants.ts, while language and curatorModes defaults are set here in state.s
There was a problem hiding this comment.
we can set them in state.ts if you prefer that. i think if i wanted to change them i would first look at constants.ts
|
The two duplicated IDs spotted by the quality gate are the last things I see, we can merge after fixing them |
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |




No description provided.