Open
Conversation
raon0211
reviewed
Apr 3, 2026
| }); | ||
|
|
||
| it("should error when no catalogs.yml exists", async () => { | ||
| workspace = await createTestWorkspace(); |
There was a problem hiding this comment.
What about using RAII pattern with await using ?
raon0211
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation used to happen implicitly during yarn install through the validateWorkspace hook, which could block installs on strict or restrict violations. This PR moves that logic into an explicit
yarn catalogs validatecommand so users can run it in CI on their own terms.The install hook still fires but everything is downgraded to warnings now. It also checks that catalogs.yml exists, that validation rules are actually configured, and that .yarnrc.yml is in sync before doing anything, so you don't get false positives from stale state.