Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughBumped project/workspace versions to a 0.3.60 pre-release, added Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pyproject.toml`:
- Line 51: The pyproject currently pins boto3 in the "iceberg" extra list
("boto3>=1.35.0"); remove that entry unless your code actually imports boto3 or
needs pyiceberg extras like "glue", "dynamodb" or "rest-sigv4". If boto3 is
required, document the reason in the pyproject (or project README) and relax the
pin to match pyiceberg's documented minimum (e.g., "boto3>=1.24.59") instead of
forcing >=1.35.0, and keep the dependency only if you explicitly use boto3 APIs
or those pyiceberg extras.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: dc689e9b-06e2-47e7-b34a-2ac2743ad3f7
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
| [project.optional-dependencies] | ||
| ai = ["huggingface-hub>=0.34.3", "ollama>=0.5.3"] | ||
| iceberg = ["polars>=1.39.3", "pyarrow>=23.0.1", "pyiceberg>=0.11.1"] | ||
| iceberg = ["polars>=1.39.3", "pyarrow>=23.0.1", "pyiceberg>=0.11.1", "boto3>=1.35.0"] |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Does pyiceberg version 0.11.1 depend on boto3 and what version range does it require?
💡 Result:
No, pyiceberg version 0.11.1 does not depend on boto3 as a core requirement. boto3 is an optional dependency required only for specific extras like 'glue', 'dynamodb', and 'rest-sigv4', with version range >=1.24.59.
Citations:
- 1: https://pypi.org/project/pyiceberg/
- 2: https://pypi.org/project/pyiceberg/0.11.1/
- 3: https://pypistats.org/packages/pyiceberg
- 4: https://github.com/apache/iceberg-python/blob/97f2d4695faf997aae2e6d2b6df129bb50efa62f/pyproject.toml
Remove or justify the explicit boto3 dependency.
boto3 is not a transitive dependency of pyiceberg 0.11.1—it's only optional for specific extras (glue, dynamodb, rest-sigv4). The code doesn't import boto3 directly or use any of these extras; S3 access is entirely delegated to pyiceberg. Unless boto3 is required for a feature not shown in the provided snippets, this dependency should be removed to avoid unnecessary bloat and version management overhead.
If boto3 is genuinely required, document the reason and note that pyiceberg expects >=1.24.59, whereas this pins >=1.35.0.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pyproject.toml` at line 51, The pyproject currently pins boto3 in the
"iceberg" extra list ("boto3>=1.35.0"); remove that entry unless your code
actually imports boto3 or needs pyiceberg extras like "glue", "dynamodb" or
"rest-sigv4". If boto3 is required, document the reason in the pyproject (or
project README) and relax the pin to match pyiceberg's documented minimum (e.g.,
"boto3>=1.24.59") instead of forcing >=1.35.0, and keep the dependency only if
you explicitly use boto3 APIs or those pyiceberg extras.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/tower-cmd/src/run.rs`:
- Around line 630-634: The code currently uses
property.environment_variable.unwrap_or_else(...) and treats Some("") as valid,
allowing an empty env key; change the logic to treat empty strings like None by
checking for non-empty values before using unwrap_or_else — e.g., use
property.environment_variable.as_deref().filter(|s| !s.is_empty()).map(|s|
s.to_string()).unwrap_or_else(||
create_pyiceberg_catalog_property_name(&catalog.name, &property.name)) so empty
strings fall back to create_pyiceberg_catalog_property_name; ensure references
to property.environment_variable, create_pyiceberg_catalog_property_name,
catalog.name and property.name are used accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 205b73e0-0898-482d-a18b-f5e4a0de22b6
📒 Files selected for processing (1)
crates/tower-cmd/src/run.rs
3 participants
Summary by CodeRabbit
Chores
New Features
Bug Fixes