Review coverage config and ratchet package coverage gates to 100% - #390
Merged
Conversation
Adopt the remaining useful patterns from covdefaults (exclude `assert_never` lines, skip fully-covered files in reports) and raise all package coverage thresholds to the current 100% baseline, making the Codecov targets explicit in a new codecov.yml. Closes #155
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up review of #155 ("Review usage of
covdefaultsand.coveragerc"):covdefaultsitself was already removed in the June 2024 coverage refactor (f39c672) — and notably, the plugin was never actually active (noplugins = covdefaultsever existed in.coveragerc), which also explains whysys.version_infoblocks stopped being excluded back then..coveragerc: add^\s*assert_never\btoexclude_lines; setskip_covered = truetox.ini: raisetests-unitgate 95 → 100 and the combined-report gate 98 → 100codecov.yml(new): make the Codecov 100% project/patch targets explicit in-repo (CI only uploads the combined report, which omitscicd_utils/*andtests/*, so these targets apply tosrc/ridgeplotonly)AGENTS.md: document the new policy — intentionally-untested lines must carry an explicit# pragma: no coverNot adopted from covdefaults (with rationale): the platform/version pragma machinery (no gated code paths exist; this is the only part that genuinely requires the plugin), the
*/__main__.py/*/setup.pyomits (none exist), and thesource = .fallback (per-suite--covtargets are more precise).Closes #155
Test plan
coverage debug configparses the new.coveragerccorrectly--cov-fail-under=100gate (237 passed, 3 xfailed; 100.0%)coverage combine+coverage report --fail-under=100(657 stmts, 0 missed, 170 branches, 0 partial)📚 Documentation preview 📚: https://ridgeplot--390.org.readthedocs.build/en/390/